This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 429843 - 'Open As Project' needs a better name
Summary: 'Open As Project' needs a better name
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Wojciech Sudol CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 03:57 EST by Dani Megert CLA
Modified: 2014-03-21 08:01 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot of the context menu. (16.01 KB, image/png)
2014-03-11 08:59 EDT, Wojciech Sudol CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2014-03-07 03:57:32 EST 
"open" has a well known meaning in Eclipse and is never used to create/import a project.

'Open As Project' should be renamed to 'Import as Project'. Note the lower case "as". A mnemonic should also be set.
Comment 1 Paul Benedict CLA 2014-03-10 11:19:11 EDT 
+1 to this. This is an import operation. The current name is misleading. I also don't like how this menu item is buried in the middle of the menu since it's really important. It would be better it it was either (1) near the top under "New" or (2) at least grouped with the "Import"/"Export" menu items.
Comment 2 Paul Webster CLA 2014-03-10 11:32:42 EDT 
Well, it's currently where it is because it was called Open (and that's where the open actions are).

I've no objection to moving it up with Import/Export if we change its name to Import.

PW
Comment 3 Wojciech Sudol CLA 2014-03-11 08:03:23 EDT 
Fix proposition: https://git.eclipse.org/r/23188

I added the "Import as Project" menu item to the Import/Export group and currently it shows up below "Export...". From a logical point of view it should be below "Import...", but visually it looks bad to me.

Moreover, when I try to position it relatively to other menu items (aMenu.insertAfter(IWorkbenchCommandConstants.FILE_IMPORT, action)) I get IAE because the IWorkbenchCommandConstants.FILE_IMPORT ID is not found. I suppose it is a matter of initialization order. How can I prevent such situation?
Comment 4 Paul Webster CLA 2014-03-11 08:34:49 EDT 
(In reply to Wojciech Sudol from comment #3)
> Fix proposition: https://git.eclipse.org/r/23188
> 
> I added the "Import as Project" menu item to the Import/Export group and
> currently it shows up below "Export...". From a logical point of view it
> should be below "Import...", but visually it looks bad to me.

There's also insertBefore (maybe the next group after PORT), insertAfter, prependToGroup.  Would one of those provide a better position?

PW
Comment 5 Wojciech Sudol CLA 2014-03-11 08:59:11 EDT 
Created attachment 240759 [details]
Screenshot of the context menu.

After testing, I think it looks best when it is on top of the group (see attached screenshot). I updated the patch.
Comment 7 Dani Megert CLA 2014-03-21 08:01:10 EDT 
Thanks for the quick fix.