This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 429729 - [Workbench] Prompt to save Unsaved Part has no title
Summary: [Workbench] Prompt to save Unsaved Part has no title
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Lars Vogel CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 00:45 EST by Sumit Singh CLA
Modified: 2014-05-30 11:09 EDT (History)
2 users (show)

See Also:

Attachments
Unsaved Part Dialog (18.48 KB, image/png)
2014-03-06 00:46 EST, Sumit Singh CLA 		no flags Details
Save Resources (19.67 KB, image/png)
2014-03-06 05:52 EST, Paul Webster CLA 		no flags Details
sample project (20.08 KB, application/x-zip-compressed)
2014-03-07 00:21 EST, Sumit Singh CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sumit Singh CLA 2014-03-06 00:45:11 EST 
I'm creating RCP application in eclipse 4 based on Compatibility layer.

When i try to close unsaved a part then unsaved changes Dialog comes but it doesn't have following

- The unsaved changes dialog has no title
- The text says "Select the parts to save"
- Its not resizeable 

For more details see the attachment.

Is there is any way or any workaround to put some title in that dialog.

Thanks,
Sumit
Comment 1 Sumit Singh CLA 2014-03-06 00:46:00 EST 
Created attachment 240575 [details]
Unsaved Part Dialog
Comment 2 Paul Webster CLA 2014-03-06 05:52:49 EST 
Created attachment 240586 [details]
Save Resources

How do you close the editors to get the dialog?  CTRL+SHIFT+W?  When I use this the dialog title says Save Resources

Please try against our M6 candidate, http://download.eclipse.org/eclipse/downloads/drops4/I20140305-2000/

PW
Comment 3 Sumit Singh CLA 2014-03-06 08:04:13 EST 
Hi Paul,

This is not editor its Part(e4). I'm using compatibility layer. I my RCP i have one part and if you set that part as dirty and try to close it without saving it then you will get this dialog.
Comment 4 Sumit Singh CLA 2014-03-06 08:06:25 EST 
Let me know if you are not able to reproduce it then I'll create and attach a small RCP.
Comment 5 Paul Webster CLA 2014-03-06 08:38:19 EST 
(In reply to sumit singh from comment #4)
> Let me know if you are not able to reproduce it then I'll create and attach
> a small RCP.

Yes, please.  It's not clear what kind of part you mean, if you are using the compatibility layer the problem should show up in the IDE.

PW
Comment 6 Sumit Singh CLA 2014-03-07 00:21:08 EST 
Created attachment 240624 [details]
sample project

Hi Paul,

Run the application and if you will close the part(In this application there is only one part) you will get the same dialog.
Comment 7 Paul Webster CLA 2014-03-27 13:17:07 EDT 
Thanks Sumit.

The problem is org.eclipse.e4.ui.workbench.renderers.swt.WBWRenderer.SaveablePartPromptDialog needs an NLSed title set on its Shell.

See https://wiki.eclipse.org/Platform_UI/How_to_Contribute

PW
Comment 8 Simon Scholz CLA 2014-03-28 17:30:06 EDT 
Proposed Solution: https://git.eclipse.org/r/#/c/24119/
Comment 10 Paul Webster CLA 2014-03-31 08:55:18 EDT 
Why was isResizable overridden in the patch?  How does that include the dialog title?

PW
Comment 11 Lars Vogel CLA 2014-03-31 08:57:38 EDT 
(In reply to Paul Webster from comment #10)
> Why was isResizable overridden in the patch?  How does that include the
> dialog title?
> 
> PW

See the bug description from comment #1.
Comment 12 Paul Webster CLA 2014-03-31 10:40:18 EDT 
While I don't mind a simple fix going in with this bug, but the bug title doesn't make it clear that it's been included.

In the future, items like that can be included in the commit message:
Bug 429729 - [Workbench] Prompt to save Unsaved Part has no title

Added title to dialog.  Also made the dialog resizable.

Signed-off-by: ...etc
Comment 13 Eric Moffatt CLA 2014-05-30 11:09:52 EDT 
Is this actually a DUP of bug 431367 ? If so are we sure we havne't fixed it in two places ?