This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 429633 - [Progress] New e4 progress view causes 184! compile warnings in official build
Summary: [Progress] New e4 progress view causes 184! compile warnings in official build
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Wojciech Sudol CLA
QA Contact: Wojciech Sudol CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-05 02:48 EST by Dani Megert CLA
Modified: 2014-03-24 05:21 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2014-03-05 02:48:52 EST 
I20140304-2000.

New e4 progress view causes 184! compile warnings in official build.

http://download.eclipse.org/eclipse/downloads/drops4/I20140304-2000/compilelogs/plugins/org.eclipse.e4.ui.progress_0.1.0.v20140303-1942/@dot.html
Comment 1 Wojciech Sudol CLA 2014-03-05 05:12:07 EST 
Most of the warnings (raw types etc.) apply to the code that is an exact copy of code from org.eclipse.ui.workbench.
Project settings pom.xml and need to be updated to ignore these warnings. Additionally some warnings can be simply fixed - is it a good idea to do this?
Comment 2 Dani Megert CLA 2014-03-05 05:34:47 EST 
(In reply to Wojciech Sudol from comment #1)
> Most of the warnings (raw types etc.) apply to the code that is an exact
> copy of code from org.eclipse.ui.workbench.
> Project settings pom.xml and need to be updated to ignore these warnings.
> Additionally some warnings can be simply fixed - is it a good idea to do
> this?

I would disable them in the official build but not in the code. That way, if someone sees warnings when editing a file, he can just fix some warning along the way.
Comment 3 Lars Vogel CLA 2014-03-05 15:30:06 EST 
(In reply to Dani Megert from comment #2)
> I would disable them in the official build but not in the code. That way, if
> someone sees warnings when editing a file, he can just fix some warning
> along the way.

Nice approach, I plan to use the same approach for Bug 423025.
Comment 4 Wojciech Sudol CLA 2014-03-05 16:00:41 EST 
Review URL: https://git.eclipse.org/r/#/c/22951/

Also 'x-friends' reference for progress view need to be added to the manifest file in org.eclipse.e4.core.services (eclipse.platform.runtime repository), but for some reason gerrit rejects my push.
Comment 5 Wojciech Sudol CLA 2014-03-05 16:19:52 EST 
Review URL for the change in org.eclipse.e4.core.services: https://git.eclipse.org/r/22953 .
Comment 7 Dani Megert CLA 2014-03-06 07:25:51 EST 
Verified in I20140305-2000.
Comment 8 Wojciech Sudol CLA 2014-03-24 05:21:04 EDT 
All warnings have been removed in code in http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=14fcb3d905696a2ca28bc5dfb589c66e5749f20f