This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 429590 - Ctrl+F10 NPE's on views with no menu
Summary: Ctrl+F10 NPE's on views with no menu
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 14:01 EST by Eric Moffatt CLA
Modified: 2014-03-06 09:42 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2014-03-04 14:01:19 EST 
Found while testing 4.4.0.I20140303-2000...

Whilst checking the fix for bug 426345 the 'real' e4 view I was using as a test didn't have a menu defined. When I tried Ctrl + F10 BAM! NPE on getting the part from the CTabItem...

	at org.eclipse.e4.ui.workbench.renderers.swt.StackRenderer.showMenu(StackRenderer.java:1244)
	at org.eclipse.e4.ui.workbench.renderers.swt.StackRenderer$6.widgetSelected(StackRenderer.java:666)

Likely we just need a null check here...
Comment 1 Dani Megert CLA 2014-03-05 03:33:38 EST 
Test Case:
1. start new workspace
2. close Welcome
3. select Outline view
4. press Ctrl+F10
Comment 3 Eric Moffatt CLA 2014-03-06 09:42:36 EST 
Verified in 4.4.0.I20140305-2000 using Dani's repo scenario...