This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 429581 - [EditorMgmt][Split editor] Split horizontal or split vertical does not work if already splitted in the other direction
Summary: [EditorMgmt][Split editor] Split horizontal or split vertical does not work i...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 11:38 EST by Lars Vogel CLA
Modified: 2014-04-29 10:57 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-03-04 11:38:00 EST 
If you split the editor horizontal and select afterwards "Split vertical" the horizontal split is removed but the editor is not split vertical.
Comment 1 Lars Vogel CLA 2014-03-04 11:39:12 EST 
Eric, I think the split command should check in which direction the editor is already splitted and if perform the split if the new split direction is different.
Comment 2 Eric Moffatt CLA 2014-03-06 15:15:15 EST 
You are most certainly correct...I'd already noticed this but wanted to get what I had out for feedback (which I guess is what this is...;-).

care to try a patch ?
Comment 3 Lars Vogel CLA 2014-03-06 17:02:03 EST 
(In reply to Eric Moffatt from comment #2)
> You are most certainly correct...I'd already noticed this but wanted to get
> what I had out for feedback (which I guess is what this is...;-).
> 
> care to try a patch ?

I don't think I will find the time for a patch. Need to fix "my" stuff for M7.
Comment 4 Eric Moffatt CLA 2014-03-25 14:12:50 EDT 
Lars, IIRC I left this because my initial code that removed the existing tag (which should have caused the 'unsplit' to happen) before adding the new tag didn't work 'out of the box', not sure why...
Comment 5 Eric Moffatt CLA 2014-03-26 11:20:08 EDT 
Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a55c55e8c76f3636f2ce651da5cc9898b332176c

This refactors the SplitHandler to allow swapping of the orientation...