This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 429184 - [Metadata] comparator errors in most recent I-builds
Summary: [Metadata] comparator errors in most recent I-builds
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 blocker (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-26 14:53 EST by David Williams CLA
Modified: 2014-02-26 23:44 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-02-26 14:53:37 EST 
Similar, but different, to bug 429101. 
Might be that some "binary differences" got "into" I-build repo, that bug 429101 fixed, but now some other bundle class file changes need to be touched to be "undone"? 

1.  eclipse.platform.ui/bundles/org.eclipse.e4.ui.workbench.swt
   no-classifier: different
      META-INF/ECLIPSE_.RSA: different
      META-INF/ECLIPSE_.SF: different
      org/eclipse/e4/ui/internal/workbench/swt/AbstractPartRenderer.class: different
      org/eclipse/e4/ui/internal/workbench/swt/PartRenderingEngine.class: different
   classifier-sources: different
      META-INF/ECLIPSE_.RSA: different
      META-INF/ECLIPSE_.SF: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [pack200, sources]

2.  eclipse.platform.ui/bundles/org.eclipse.e4.ui.workbench.addons.swt
   no-classifier: different
      META-INF/ECLIPSE_.RSA: different
      META-INF/ECLIPSE_.SF: different
      org/eclipse/e4/ui/workbench/addons/dndaddon/DnDManager.class: different
      org/eclipse/e4/ui/workbench/addons/dndaddon/DropAgent.class: different
   classifier-sources: different
      META-INF/ECLIPSE_.RSA: different
      META-INF/ECLIPSE_.SF: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [pack200, sources]
Comment 1 Paul Webster CLA 2014-02-26 15:24:15 EST 
This is the opposite of the last bug, where those bundles changed and picked up the source change but didn't change now and so have the old signature in them

Sigh ... that means we need another I build.  I'll push the fix shortly

PW
Comment 2 Paul Webster CLA 2014-02-26 15:40:52 EST 
The full list of bundles that would be effected:

bash-4.1$ find * -name *.java -print0 | xargs -0 grep getContainingContext | cut -f2 -d/ | sort -u
org.eclipse.e4.ui.model.workbench
org.eclipse.e4.ui.tests
org.eclipse.e4.ui.workbench
org.eclipse.e4.ui.workbench.addons.swt
org.eclipse.e4.ui.workbench.renderers.swt
org.eclipse.e4.ui.workbench.renderers.swt.cocoa
org.eclipse.e4.ui.workbench.swt
org.eclipse.ui.tests
org.eclipse.ui.workbench

Here's what was updated in the noon  build already:

bash-4.1$ git diff --name-only I20140225-1430..I20140226-1200 | cut -f2 -d/ | sort -u
org.eclipse.e4.ui.model.workbench
org.eclipse.e4.ui.tests
org.eclipse.e4.ui.workbench
org.eclipse.e4.ui.workbench.renderers.swt
org.eclipse.e4.ui.workbench.renderers.swt.cocoa
org.eclipse.ui.workbench

So I'll update org.eclipse.e4.ui.workbench.addons.swt, org.eclipse.e4.ui.workbench.swt, and org.eclipse.ui.tests
Comment 4 Paul Webster CLA 2014-02-26 16:12:35 EST 
Without this fix, you can't start up the I build at all.

PW
Comment 5 David Williams CLA 2014-02-26 23:44:01 EST 
verified no comparator errors in 
http://download.eclipse.org/eclipse/downloads/drops4/I20140226-1700/

And the workbench even starts up! :)