Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 428895 - Adding a processor for the new context spy
Summary: Adding a processor for the new context spy
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-24 07:05 EST by Olivier Prouvost CLA
Modified: 2014-03-03 12:44 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Prouvost CLA 2014-02-24 07:05:14 EST
The context spy is now in Eclipse, but we have to add it manually in an application project to use it. 

I started a processor to add automatically the key binding to open it like the live model editor for instance. 

I propose to use Alt Shift F10, it seems to be free for the moment. Any comment ? 


Another idea : It could also be cool to have only one main 'debug' window containing the live model editor, the event spy, context spy, css spy, ...  to avoid multiple short cuts for each spy. Each spy could share code to check if this debug window is available in model, and add itself in its part stack... Discussion is opened here...
Comment 1 Wim Jongman CLA 2014-02-24 07:43:40 EST
(In reply to Olivier Prouvost from comment #0)
> 
> I propose to use Alt Shift F10, it seems to be free for the moment. Any
> comment ? 

+1 if it's free.

 
> Another idea : It could also be cool to have only one main 'debug' window
> containing the live model editor, the event spy, context spy, css spy, ... 
> to avoid multiple short cuts for each spy. Each spy could share code to
> check if this debug window is available in model, and add itself in its part
> stack... Discussion is opened here...

+1 great idea.
Comment 2 Daniel Rolka CLA 2014-02-24 08:06:35 EST
(In reply to Olivier Prouvost from comment #0)

> Another idea : It could also be cool to have only one main 'debug' window
> containing the live model editor, the event spy, context spy, css spy, ... 
> to avoid multiple short cuts for each spy. Each spy could share code to
> check if this debug window is available in model, and add itself in its part
> stack... Discussion is opened here...

I agree, it is great idea. 

I think another item that is worth to consider is moving of some common functionality used by each spy to the common bundle in order to follow the DRY rule (i.e. registration of the key bindings, logging, saving the state, ...)

Daniel
Comment 3 Olivier Prouvost CLA 2014-02-24 08:10:49 EST
Ok. I will open another bug for the common stuff of spies. Discussion will go on inside...

I found also a strange behavior with the live model editor which is added and added as part descriptor when you launch and relaunch application... May be due to the bug on processors (model is stored and when application is restarted, the processors seems to be processed before the ui part of the model is full initialized...)...
Comment 4 Olivier Prouvost CLA 2014-03-03 12:22:53 EST
Fixed in review : https://git.eclipse.org/r/#/c/22776/
Comment 5 Lars Vogel CLA 2014-03-03 12:44:32 EST
(In reply to Olivier Prouvost from comment #4)
> Fixed in review : https://git.eclipse.org/r/#/c/22776/

Can you include the URL to the commit in future bugs? You find the link under https://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/

This bug was fixed with https://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?id=3b7e380768de391ca5246199800683507fbf668c