Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 428892 - Enable default text encoding should be set to UTF-8 for Eclipse SDK build
Summary: Enable default text encoding should be set to UTF-8 for Eclipse SDK build
Status: CLOSED DUPLICATE of bug 108668
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-24 06:16 EST by Lars Vogel CLA
Modified: 2014-02-24 10:41 EST (History)
4 users (show)

See Also:


Attachments
Screenshot (111.54 KB, image/png)
2014-02-24 08:48 EST, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-02-24 06:16:20 EST
Just noticed Bug 108668 and Bug 421702 for EPP. 

I suggest to set the enable to UTF-8 for our SDK build.
Comment 1 Lars Vogel CLA 2014-02-24 06:16:34 EST
s/enable/encoding
Comment 2 David Williams CLA 2014-02-24 08:30:36 EST
I think we do already ... see 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse-platform-parent/pom.xml#n58

and 

bug 399441 for the history of when we made this change. (when we moved to Tycho builder .... just because so much else was changing any way). 

If you mean each 'project' should have it set explicitly, then there are, probably, some that do not ... I think we used to have a bug for that as well? 

So, can you clarify what you mean?
Comment 3 Lars Vogel CLA 2014-02-24 08:48:50 EST
Created attachment 240262 [details]
Screenshot

(In reply to David Williams from comment #2)

> So, can you clarify what you mean?

Sorry for being unclear. I suggest to set the default encoding in the preference to UTF-8 (see screenshot). We could set the corresponding setting in our plugin_customization.ini. The project setting could still override that.
Comment 4 Thomas Schindl CLA 2014-02-24 09:03:45 EST
I can't do that because you'll break existing workspaces with no setting
Comment 5 David Williams CLA 2014-02-24 10:02:24 EST
How is this not a pure dup of 108668 ... but, yes, agree with Tom. It'd risk breaking existing workspaces/projects. And no one likes us breaking their data.
Comment 6 Lars Vogel CLA 2014-02-24 10:41:28 EST
(In reply to David Williams from comment #5)
> How is this not a pure dup of 108668 ... but, yes, agree with Tom. It'd risk
> breaking existing workspaces/projects. And no one likes us breaking their
> data.

I think Bug 108668 is for the general change and I suggest this a a customizing change for the SDK, but breaking data is really not good. I mark it as dup.

*** This bug has been marked as a duplicate of bug 108668 ***