Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #428722 +++ While working on bug 419647 it was once stated "we don't include source from orbit bundles". Knowing that we usually do, I looked at a recent SDK to see what was missing and what was not. The list below pretty much says it all. No source in Orbit (not much we can do) org.sat4j.core_2.3.5.v201308161310.jar org.sat4j.pb_2.3.5.v201308161310.jar javax.xml_1.3.4.v201005080400.jar There is source in Orbit (should be "easy" to include in SDK) org.w3c.css.sac_1.3.1.v200903091627.jar org.w3c.dom.smil_1.0.0.v200806040011.jar org.w3c.dom.svg_1.1.0.v201011041433.jar org.apache.batik.css_1.7.0.v201011041433.jar org.apache.batik.util_1.7.0.v201011041433.jar org.apache.batik.util.gui_1.7.0.v200903091627.jar org.apache.commons.codec_1.6.0.v201305230611.jar org.apache.httpcomponents.httpclient_4.2.6.v201311072007.jar org.apache.httpcomponents.httpcore_4.2.5.v201311072007.jar Source correctly contained in SDK (no action required) com.ibm.icu_50.1.1.v201304230130.jar com.ibm.icu.source_50.1.1.v201304230130.jar com.jcraft.jsch_0.1.50.v201310081430.jar com.jcraft.jsch.source_0.1.50.v201310081430.jar com.sun.el_2.2.0.v201303151357.jar com.sun.el.source_2.2.0.v201303151357.jar javax.annotation_1.2.0.v201401042248.jar javax.annotation.source_1.2.0.v201401042248.jar javax.el_2.2.0.v201303151357.jar javax.el.source_2.2.0.v201303151357.jar javax.inject_1.0.0.v20091030.jar javax.inject.source_1.0.0.v20091030.jar javax.servlet_3.0.0.v201112011016.jar javax.servlet.source_3.0.0.v201112011016.jar javax.servlet.jsp_2.2.0.v201112011158.jar javax.servlet.jsp.source_2.2.0.v201112011158.jar org.apache.ant_1.9.2.v201307241445 org.apache.ant.source_1.9.2.v201307241445.jar org.apache.commons.logging_1.1.1.v201101211721.jar org.apache.commons.logging.source_1.1.1.v201101211721.jar org.apache.felix.gogo.command_0.10.0.v201209301215.jar org.apache.felix.gogo.command.source_0.10.0.v201209301215.jar org.apache.felix.gogo.runtime_0.10.0.v201209301036.jar org.apache.felix.gogo.runtime.source_0.10.0.v201209301036.jar org.apache.felix.gogo.shell_0.10.0.v201212101605.jar org.apache.felix.gogo.shell.source_0.10.0.v201212101605.jar org.apache.jasper.glassfish_2.2.2.v201205150955.jar org.apache.jasper.glassfish.source_2.2.2.v201205150955.jar org.apache.lucene.analysis_3.5.0.v20120725-1805.jar org.apache.lucene.analysis.source_3.5.0.v20120725-1805.jar org.apache.lucene.core_3.5.0.v20120725-1805.jar org.apache.lucene.core.source_3.5.0.v20120725-1805.jar org.hamcrest.core_1.3.0.v201303031735.jar org.hamcrest.core.source_1.3.0.v201303031735.jar org.junit_4.11.0.v201303080030 org.junit.source_4.11.0.v201303080030.jar org.objectweb.asm_3.3.1.v201105211655.jar org.objectweb.asm.source_3.3.1.v201105211655.jar org.w3c.dom.events_3.0.0.draft20060413_v201105210656.jar org.w3c.dom.events.source_3.0.0.draft20060413_v201105210656.jar
Created attachment 240232 [details] patch to not exclude 6 source bundles I'm not sure why these bundles were ever added to the "excludes" list, but believe they should not be excluded. There is source for them, so ... why not include it? (These might have been excluded in the earliest versions where there was an effort to get the CBI build to "match exactly" the PDE build ... and they were simply not included in PDE build by mistake/oversite).
And, remember, if this "pom change" is the only change made, from one I-build to another, then something else should be touched, such as adding ug 428835 - Some Orbit bundles missing source in SDK to the file forceQualifierUpdate.txt
FWIW, I did a "local build" with this change, and it went fine. Included the source ... and none seem prohibitively large or anything 52K org.w3c.css.sac.source_1.3.1.v200903091627.jar 16K org.w3c.dom.smil.source_1.0.0.v200806040011.jar 80K org.w3c.dom.svg.source_1.1.0.v201011041433.jar 308K org.apache.batik.css.source_1.7.0.v201011041433.jar 136K org.apache.batik.util.source_1.7.0.v201011041433.jar 76K org.apache.batik.util.gui.source_1.7.0.v200903091627.jar
I agree an SDK should hold all source bundles - why don't we have sources from sat4j and javax.xml?
(In reply to Thomas Schindl from comment #4) > I agree an SDK should hold all source bundles - why don't we have sources > from sat4j and javax.xml? Short answer: there is no sources for those in the Orbit project. Long answer: no one (so far) has been willing to do the work.
Well the CQ should hold the source: * org.sat4j.core_2.3.5: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7311 * org.sat4j.pb_2.3.5: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7311 * javax.xml: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=1448 I guess we should file orbit bugs - I'll try to take care of them if the maintainers don't - it always drives me crazy when I need to debug something and the source is missing.
(In reply to Thomas Schindl from comment #6) > Well the CQ should hold the source: > * org.sat4j.core_2.3.5: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7311 > * org.sat4j.pb_2.3.5: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7311 > * javax.xml: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=1448 > > I guess we should file orbit bugs - I'll try to take care of them if the > maintainers don't - it always drives me crazy when I need to debug something > and the source is missing. Well, not to be negative, but, I think the maintainers already would have, if they would have been willing ... but, for what ever reason they weren't, so I'm sure they'd appreciate someone else doing it. Notice too those CQs say "binary", so one of the first steps would be sure they can be changed to distribute both "binary and source" ... I've not really known any cases where that hasn't been possible ... but ... I don't know ... is some amount of extra work. Thanks for your interest. Now if we can just get these 6 bundles in :)
The fix to pom was made as part of 434039. Not sure we updated "forcequaliferupdate"? But, I assume so, as I now see org.apache.batik.css.source in repo.
Looks complete (except for those with no source in Orbit): org.sat4j.core org.sat4j.pb javax.xml Nice.
