This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 428429 - [eslint] Provide a NLS rule (was: Build NLS checking into the JS tools)
Summary: [eslint] Provide a NLS rule (was: Build NLS checking into the JS tools)
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 9.0   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 464538
Blocks: 464609
  Show dependency tree
 
Reported: 2014-02-18 09:00 EST by Michael Rennie CLA
Modified: 2015-04-14 16:27 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2014-02-18 09:00:43 EST 
We should build the checking of JS code for missing / wrong NLS stuff into the JS tools itself, perhaps even as an eslint rule.
Comment 1 Michael Rennie CLA 2014-03-06 23:21:53 EST 
To make this work as a rule we would have to turn (back) on loc nodes in our AST, which has the negative effect of bloating the size of the AST.
Comment 2 Curtis Windatt CLA 2015-04-13 16:22:04 EDT 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=430a5eace6521520eb3305dc4524d8ff42cc4a64

Added new rule, new quickfix and tests for both.  Rule is set to ignore by default.