Community
Participate
Working Groups
Currently the SearchField in the Quick Access looks like a search box, which I think is misleading for the user. It is not a search box, it allows to trigger command. I suggest to remove the search icon and allow that the cancel its input.
https://git.eclipse.org/r/21919
I don't mind if we can cancel the field, but marking it as a search field was deliberate. PW
Created attachment 239884 [details] Screenshot I also think it looks much better.
(In reply to Paul Webster from comment #2) > I don't mind if we can cancel the field, but marking it as a search field > was deliberate. And you still like it that way? From my Eclipse training sessions, I have the impression that the search symbol is misleading. If you like it, I put it in again.
(In reply to Lars Vogel from comment #4) > > And you still like it that way? From my Eclipse training sessions, I have > the impression that the search symbol is misleading. If you like it, I put > it in again. Yes, it's a search field (it searches commands, menu items, editors, views, perspectives, etc). But being able to clear the field sounds good. Does just adding the SWT.CANCEL allow it to clear the field? PW
(In reply to Paul Webster from comment #5) > Yes, it's a search field (it searches commands, menu items, editors, views, > perspectives, etc). I think it is not. A search box allows to search for something. Quick Access does not allow to search; it allows to execute a command. If that would be a search, our search view would be really badly implemented. ;-) > But being able to clear the field sounds good. Does just adding the > SWT.CANCEL allow it to clear the field? Correct. I do that change and I leave the search icon intact (even though I disagree with our opinion). Remark: Maybe we can use the EclispeCon workshop to query our users about that search icon? My poll in my last training session was: 5 out of 5 did not know about this box and assume it was a kind of text search. Also a quick poll via Twitter resulted in the same https://twitter.com/vogella/status/434008331976728576
(In reply to Lars Vogel from comment #6) > I think it is not. A search box allows to search for something. Quick Access > does not allow to search; it allows to execute a command. If that would be a > search, our search view would be really badly implemented. ;-) It searches through all of the menus, tool items, commands, views, perspectives, editors, preferences, properties, and wizards. When it's finally extensible it'll offer more. It's not restricted to commands. It's the modelled after a finder on the mac. PW
(In reply to Paul Webster from comment #7) > (In reply to Lars Vogel from comment #6) > > I think it is not. A search box allows to search for something. Quick Access > > does not allow to search; it allows to execute a command. If that would be a > > search, our search view would be really badly implemented. ;-) > > It searches through all of the menus, tool items, commands, views, > perspectives, editors, preferences, properties, and wizards. When it's > finally extensible it'll offer more. It's not restricted to commands. It's > the modelled after a finder on the mac. I mean commands in the sense "all available stuff I can do". But I'm OK with leaving the search icon. In case of disagreement I think the current status quo is probably the best.
Created attachment 239922 [details] Screenshot To show both icons (cancel is displayed always under Linux) I also have to increase the box size so that the text is visible.
Created attachment 239923 [details] Quick Access with tooltip instead of message After playing around with several setups, I think I found a nice looking solution. If I move the "Quick Access" text to the toolbar I can make the box a bit smaller which make the whole thing look IMHO a bit more elegant. To test this, please use the updated Gerrit review. https://git.eclipse.org/r/#/c/21919/4
(In reply to Lars Vogel from comment #10) Review (without revision) https://git.eclipse.org/r/#/c/21919/
I prefer the text in, but if Dani or John have no objections I'll withdraw mine. PW
(In reply to Paul Webster from comment #12) > I prefer the text in, but if Dani or John have no objections I'll withdraw > mine. > > PW John / Dani, let me know if you have objections. I would like to add the "Cancel" icon to the Search box (aka as Quick Access) but if I leave the background message this would increase the size of the box. Hence I suggest to move the text to a tooltip. Also looks better IMHO.
Isn't having the test in the search field (usually greyed out) fairly common now ? That being said I expect that we're going to get flamed if we 'waste' any more space in the main toolbar (especially height). I wonder whether we need all the icons, perhaps only 'clear' would suffice ? Would that leave enough room for the string to appear when it's 'empty' ? I'm basing this off the idea that Eclipse is primarily used by people more closely connected to computing that your average grandma (who may well need all the hints they can get).
(In reply to Eric Moffatt from comment #14) > Isn't having the test in the search field (usually greyed out) fairly common > now ? > > That being said I expect that we're going to get flamed if we 'waste' any > more space in the main toolbar (especially height). > > I wonder whether we need all the icons, perhaps only 'clear' would suffice ? > Paul likes the search icon, I wanted to remove it. If we remove it, the Text could stay.
(In reply to Lars Vogel from comment #15) > (In reply to Eric Moffatt from comment #14) > > Isn't having the test in the search field (usually greyed out) fairly common > > now ? > > > > That being said I expect that we're going to get flamed if we 'waste' any > > more space in the main toolbar (especially height). > > > > I wonder whether we need all the icons, perhaps only 'clear' would suffice ? Dani or John do you have an opinion here for the Quick Access box? We have the following options if we want to add the "Cancel" icon. 1.) Increase the size of the box to fix the Search, Cancel icon and the message -> I think that is a no-go 2.) Remove the Search icon -> Eric seems to be in favor, Paul not, I'm also in favor of that option. 3.) Remove the message and define it as tooltip
(In reply to Paul Webster from comment #12) > I prefer the text in, but if Dani or John have no objections I'll withdraw > mine. > > PW The text in the field is correct. Using tool tips for entry fields is not good style. Adding 'Cancel' seems overkill here. Suggest to close as WONTFIX.
(In reply to Dani Megert from comment #17) > (In reply to Paul Webster from comment #12) > > I prefer the text in, but if Dani or John have no objections I'll withdraw > > mine. > > > > PW > > The text in the field is correct. Using tool tips for entry fields is not > good style. > > Adding 'Cancel' seems overkill here. > > Suggest to close as WONTFIX. Thanks. What about the "Search" icon, which I find displaced (it is not a search box IMHO). Paul likes it. Can you also share you opinion on it?
(In reply to Lars Vogel from comment #18) > Thanks. What about the "Search" icon, which I find displaced (it is not a > search box IMHO). Paul likes it. Can you also share you opinion on it? Oh, I never noticed this, since it doesn't show up on Windows. I agree that we should not use the search icon here.
(In reply to Dani Megert from comment #19) > (In reply to Lars Vogel from comment #18) > > Thanks. What about the "Search" icon, which I find displaced (it is not a > > search box IMHO). Paul likes it. Can you also share you opinion on it? > > Oh, I never noticed this, since it doesn't show up on Windows. I agree that > we should not use the search icon here. If it does not show up on Window, this is one more reason to remove it. I think the UI should be (relatively) consistent.
(In reply to Lars Vogel from comment #20) > (In reply to Dani Megert from comment #19) Updated the Gerrit review. Without the icon under Linux the size of the box also be reduced a bit. This should also help with the complaints about wasted space, as for example in https://bugs.eclipse.org/bugs/show_bug.cgi?id=362420#c73 Dani, could you please test the change in the Gerrit to see if the Quick Access box looks still good under Window with the reduced size? https://git.eclipse.org/r/#/c/21919/
Some focus weirdness with Quick Access: Type 't' into Quick Access and click the border of the popup. Focus switches between the popup window and workbench a couple of times and goes back to workbench. This occurs on Windows 8.1 and Eclipse SDK 4.2.0 but not on Eclipse SDK 4.1.0. Also this might be unrelated, but after testing that a few times focus changes (especially to Mylyn) are now really sluggish. Time to restart the workbench, I guess.
(In reply to Timo Kinnunen from comment #22) > Some focus weirdness with Quick Access: > > Type 't' into Quick Access and click the border of the popup. Focus switches > between the popup window and workbench a couple of times and goes back to > workbench. This occurs on Windows 8.1 and Eclipse SDK 4.2.0 but not on > Eclipse SDK 4.1.0. Also this might be unrelated, but after testing that a > few times focus changes (especially to Mylyn) are now really sluggish. Time > to restart the workbench, I guess. This seems not related to this bug.
(In reply to Lars Vogel from comment #21) > Dani, could you please test the change in the Gerrit to see if the Quick > Access box looks still good under Window with the reduced size? Size is calculated based based on the average font size, so I guess it should be OK for Windows.
(In reply to comment #23) > This seems not related to this bug. Being a regression it doesn't quite match with "improve", true. On the other hand, it not apparently breaking any existing functionality but only making it look bad matches quite well with "improve the look and feel". Finally as a practical consideration, since I suspect but can't confirm that the underlying cause is really somewhere in the platform's misbehaving focus and z-order handling rather than with Quick Access, realistically the odds of focus handling actually getting fixed are better if it is shown to block a higher-profile bug. It is for that last reason that it should be considered as part of this bug. Otherwise it'll just end up as a duplicate of bug 24052 or similar.
(In reply to Timo Kinnunen from comment #25) > (In reply to comment #23) > > This seems not related to this bug. > > Being a regression it doesn't quite match with "improve", true. On the other > hand, it not apparently breaking any existing functionality but only making > it look bad matches quite well with "improve the look and feel". Finally as > a practical consideration, since I suspect but can't confirm that the > underlying cause is really somewhere in the platform's misbehaving focus and > z-order handling rather than with Quick Access, realistically the odds of > focus handling actually getting fixed are better if it is shown to block a > higher-profile bug. It is for that last reason that it should be considered > as part of this bug. Otherwise it'll just end up as a duplicate of bug 24052 > or similar. It is really not related to this change. Please open a new bug or comment on the existing bug.
(In reply to Lars Vogel from comment #21) > (In reply to Lars Vogel from comment #20) > > (In reply to Dani Megert from comment #19) > > Updated the Gerrit review. Without the icon under Linux the size of the box > also be reduced a bit. This should also help with the complaints about > wasted space, as for example in > https://bugs.eclipse.org/bugs/show_bug.cgi?id=362420#c73 > > Dani, could you please test the change in the Gerrit to see if the Quick > Access box looks still good under Window with the reduced size? > > https://git.eclipse.org/r/#/c/21919/ The reduced size didn't work well. Lars updated the change again. Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ee0cee80446f62f13fd72ecfd8180bead8dfaf45
Verified in Build id: I20140303-2000
