Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 42802 - [KeyBindings] CTRL ENTER behaviour, maximize editor window should be changed.
Summary: [KeyBindings] CTRL ENTER behaviour, maximize editor window should be changed.
Status: RESOLVED DUPLICATE of bug 42225
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-09 11:54 EDT by Johan Compagner CLA
Modified: 2003-09-12 12:48 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Compagner CLA 2003-09-09 11:54:11 EDT
in the latest builds we have suddenly CTRL-ENTER that maximizes the current 
editor window. That you have a key combo for that is nice but it shouldn't be 
CTRL-ENTER by default!

because for example JFaceDbc (sql plugin) uses that ctrl-enter combo to execute 
te current sql that is under the cursor/caret. (Something that comes from toad 
and is very common for those kind of operations)

But also a thing from eclipse itself doesn'twork anymore:
Eclipse has a feature that Completion inserts or Completions overrides with 
code completion.
And if you do override then with holding the CTRL key you can go back to insert 
mode. But this doesn't work now anymore because you can't press enter..
Comment 1 Douglas Pollock CLA 2003-09-10 12:35:45 EDT
What build are you using?  Can you reproduce on I20030909?  What locale are you
using?  I can't reproduce on Windows XP using I20030909 on a US locale.  I swear
I've seen this before and fixed it.  But, I can't find the old bug, and can't be
sure.

See Bug 42225 for a similar problem.

BTW, the problem you're seeing is tied to how "Ctrl+" works with key events. 
The system sees your key stroke as "Ctrl+M" and somehow our conversion back to
"Ctrl+Return" isn't working (in KeySupport - org.eclipse.ui.workbench). 
"Ctrl+M" is bound to "maximize editor".


(moving to P4 -- waiting for response)
Comment 2 Johan Compagner CLA 2003-09-10 16:38:44 EDT
I just installed 20030910 (ibuild)
And did install any plugins and i did use a complete new workspace.

right after loading eclipse, is see the welcom editor.
I give that editor focus and press CTRL-ENTER, and it the editor maximizes.
CTRL-M also works.

these are my locale settings (configuration details)
user.country=NL
user.language=nl
user.timezone=Europe/Berlin

When do you say it should be fixed in what build?
Because everybody i know that is using M3 or later does have this problem.
A few ibuild before M3 this didn't happen, it started to happen somewhere in 
the middel of M2->M3 i believe.


Comment 3 Douglas Pollock CLA 2003-09-12 09:00:57 EDT
Opening any dialog and pressing a key within the dialog freezes the keyboard
input and blocks keyboard accelerators from working.  Mouse continues to
function, and Eclipse is still responsive.  Keyboard continues to work in other
applications even while keyboard input is frozen in Eclipse.  Dialogs can be
opened and navigated with a mouse (and closed with a mouse), and keyboard input
continues to work.

No freezes noticed yet from input into non-dialog windows.
Comment 4 Douglas Pollock CLA 2003-09-12 09:01:29 EDT
Sorry, last comment was for another bug.
Comment 5 Douglas Pollock CLA 2003-09-12 12:48:46 EDT
Applying the patch attached to Bug 42225 makes this problem go away.  This
problem exists on all locales on I20030910.  A more elegant solution from SWT is
hoped for.

*** This bug has been marked as a duplicate of 42225 ***