Comment 1 Mickael Istria 2014-02-11 12:07:26 EST

https://git.eclipse.org/r/21821

Comment 2 Paul Webster 2014-02-14 13:22:05 EST

Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f3c2e454203de34c5dee2475ed7d504b633f08b7

Thanks Mickael

PW

Comment 3 Dani Megert 2014-02-15 04:23:33 EST

This is causes new compile warning in the official build. Please fix.

http://download.eclipse.org/eclipse/downloads/drops4/N20140214-2000/compilelogs/plugins/org.eclipse.ui.navigator.resources_3.4.700.N20140214-2000/@dot.html

Comment 4 Dani Megert 2014-02-18 06:51:53 EST

(In reply to Dani Megert from comment #3)
> This is causes new compile warning in the official build. Please fix.
> 
> http://download.eclipse.org/eclipse/downloads/drops4/N20140214-2000/
> compilelogs/plugins/org.eclipse.ui.navigator.resources_3.4.700.N20140214-
> 2000/@dot.html

Ping!

Comment 5 Mickael Istria 2014-02-18 07:05:46 EST

I'm not sure what should be done here. The warnings happen because we added generics where there used to be simple cast. Having generic that way is as (not) safe as doing a cast.
How can such code be checked?
An easy solution seems to be add @suppressWarnings("unchecked") but is this really the path we want the platform code to take? Hiding warnings is way worse than keeping them visible.

Comment 6 Paul Webster 2014-02-18 10:22:27 EST

(In reply to Mickael Istria from comment #5)
> How can such code be checked?
> An easy solution seems to be add @suppressWarnings("unchecked") but is this
> really the path we want the platform code to take? Hiding warnings is way
> worse than keeping them visible.

If it cannot be checked then yes, please, suppress the warnings.

PW

Comment 7 Mickael Istria 2014-02-19 00:59:34 EST

Hey Lars, how do you usually deal with such warnings with generics?

Comment 8 Lars Vogel 2014-02-19 02:34:32 EST

(In reply to Mickael Istria from comment #7)
> Hey Lars, how do you usually deal with such warnings with generics?

If it is a private field or method I typically change it to include the type information. If its API which cannot be easily adjusted I think @suppressWarnings("unchecked") is fine. I hope that over time we will be able to move lots of API to generics.

Comment 9 Mickael Istria 2014-02-19 03:20:56 EST

Added some suppressWarning then: https://git.eclipse.org/r/#/c/22202/

Comment 10 Dani Megert 2014-02-19 09:19:07 EST

Adding M6 back as the fix is close.

Comment 11 Dani Megert 2014-02-21 10:41:13 EST

(In reply to Mickael Istria from comment #9)
> Added some suppressWarning then: https://git.eclipse.org/r/#/c/22202/

Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b0ce805681c1fb08fabd004c1b34319a0d385d53.

Comment 12 Lars Vogel 2014-03-04 13:44:39 EST

Strange to see that org.eclipse.ui.navigator is still on Java Verified in Git

Comment 13 Lars Vogel 2014-03-04 13:45:21 EST

Strange to see that org.eclipse.ui.navigator is still on Java 1.4, but org.eclipse.ui.navigator.resource is now based on Java 1.6.   Verified in Git