This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 427403 - Exclude org.eclipse.ui.examples.rcp.mail from the platform build
Summary: Exclude org.eclipse.ui.examples.rcp.mail from the platform build
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-04 14:48 EST by Lars Vogel CLA
Modified: 2014-03-19 23:17 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-02-04 14:48:35 EST
I see that we exclude the examples from the build, e.g., org.eclipse.e4.demo.contacts except
 
org.eclipse.ui.tutorials.rcp.part1
org.eclipse.ui.tutorials.rcp.part2
org.eclipse.ui.tutorials.rcp.part3

Any reason for that? I think we should exclude the "old" rcp tutorials also from the build.
Comment 1 Lars Vogel CLA 2014-02-04 14:49:30 EST
David or Paul, you probably know why this happened. Please let me know if I can exclude the rcp bundles from the build.
Comment 2 Paul Webster CLA 2014-02-04 15:30:27 EST
We normally keep those examples in the build to confirm we haven't broken an 3.x RCP apps with our compatibility layer.

PW
Comment 3 David Williams CLA 2014-02-04 16:16:38 EST
I think we should remove them, if not delivered. 

(There might have been merit in the beginning to build them, to make sure they still compiles, but at this point, I don't think that'd be very "conclusive" that something was not broken -- and if really needed, should be more of a test, than just seeing if they compiled?). 

My 2 cents.
Comment 4 Lars Vogel CLA 2014-02-05 06:41:28 EST
(In reply to David Williams from comment #3)
> I think we should remove them, if not delivered. 
> 
> (There might have been merit in the beginning to build them, to make sure
> they still compiles, but at this point, I don't think that'd be very
> "conclusive" that something was not broken -- and if really needed, should
> be more of a test, than just seeing if they compiled?). 
> 

I'm also in favor of removing them from the build, if OK for Paul I remove them. Especially as the other examples are already removed. 


Note: Maybe we can have another build which we run via Hudson to check that the examples still build? (but that would be another bug report)
Comment 5 Lars Vogel CLA 2014-03-19 12:31:38 EDT
https://git.eclipse.org/r/23616
Comment 7 Lars Vogel CLA 2014-03-19 23:17:48 EDT
Build still running