Community
Participate
Working Groups
org.eclipse.ui.ide.application currently has 11 warnings. I suggest we fix them.
This Gerrit address some of the warnings: https://git.eclipse.org/r/21443
I see also the following warning but have no idea how to fix it, tips are welcomeÖ 'source.e4-ide-application.jar' build entry is missing build.properties /org.eclipse.ui.ide.application
(In reply to Lars Vogel from comment #1) > This Gerrit address some of the warnings: https://git.eclipse.org/r/21443 Have we just silently been throwing away those 2 menu items? Or is that a placeholder, where they appear if the update manager plugins are available? PW
(In reply to Paul Webster from comment #3) > (In reply to Lars Vogel from comment #1) > > This Gerrit address some of the warnings: https://git.eclipse.org/r/21443 > > Have we just silently been throwing away those 2 menu items? Or is that a > placeholder, where they appear if the update manager plugins are available? > > PW I think these are the "old" update menu items before we started using the p2 update items. I assume they have been forgotten to replace in the migration to p2.
The menu items where there to allow switching back to the old Update Manager, but since we fixed bug 311590 I think we can remove them now. Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f91ea1ed14d9eaeb803d4da62971e6f4e14afaa0
Thanks Dani, I see also the following warning but have no idea how to fix it, tips are welcome. 'source.e4-ide-application.jar' build entry is missing build.properties /org.eclipse.ui.ide.application
(In reply to Lars Vogel from comment #6) > Thanks Dani, I see also the following warning but have no idea how to fix > it, tips are welcome. > > 'source.e4-ide-application.jar' build entry is missing build.properties > /org.eclipse.ui.ide.application This was added in the early days of e4 (see bug 275672) to allow patching the bundles with e4 fragments. If you'd import those fragments, then the warnings would go away. I'm not sure that we still need this. Hence the fix would probably be to remove it from the manifests.
Paul, can you confirm this? If it is no longer used, then we can remove the e4 fragment JARs in all places in one go.
(In reply to Dani Megert from comment #7) > Hence the fix > would probably be to remove it from the manifests. Patch for org.eclipse.ui.ide.application MANIFEST.MF https://git.eclipse.org/r/#/c/21663/
I see two other usages of e4*.jars in platform.ui: org.eclipse.ui.ide with e4-ide.jar org.eclpse.ui.workbench with e4-workbench.jar I wait for Pauls confirmation and if positive I remove these entries as well.
(In reply to Lars Vogel from comment #10) > I see two other usages of e4*.jars in platform.ui: > > org.eclipse.ui.ide with e4-ide.jar > org.eclpse.ui.workbench with e4-workbench.jar Yes, that's what I see too. > I wait for Pauls confirmation and if positive I remove these entries as well. Thanks!
(In reply to Dani Megert from comment #11) > > I wait for Pauls confirmation and if positive I remove these entries as well. Have not seen any feedback, in general I assume no feedback means "I guess OK". :-)
Also found compatibility.jar in org.eclipse.ui.workbench without any file to match that.
Update Gerrit review, I plan to apply this soon, if I hear not otherwise https://git.eclipse.org/r/#/c/21663/
(In reply to Lars Vogel from comment #10) > I see two other usages of e4*.jars in platform.ui: > > org.eclipse.ui.ide with e4-ide.jar > org.eclpse.ui.workbench with e4-workbench.jar Right, all of these entries were to allow us to patch the workbench or IDE with e4 fragments. Then we gutted the workbench and went another way. They can be removed (we would just lose are ability to patch those plugins with a fragment, but it wasn't high on our list of things to do anyway). PW
(In reply to Paul Webster from comment #15) > They can be removed (we would just lose are ability to patch those plugins > with a fragment, but it wasn't high on our list of things to do anyway). > > PW Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=45b6a2d1256d65986340b58bc0c0f0f82ce4db8b I mark this bug as fixed, even though there is still one type of warning left in the plug-in but I plan to tackle that at a later point in time.
(In reply to Lars Vogel from comment #16) > Fixed with > https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=45b6a2d1256d65986340b58bc0c0f0f82ce4db8b I had missing commits as dependency. I resolved that and committed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=82a9b2cbb106f588224fab2dbf8554324e5116ea
