Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 427190 - add YouTrack connector to Connector Discovery listing
Summary: add YouTrack connector to Connector Discovery listing
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Alexander Marchuk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 279709
  Show dependency tree
 
Reported: 2014-02-01 08:24 EST by Alexander Marchuk CLA
Modified: 2014-06-27 16:26 EDT (History)
1 user (show)

See Also:


Attachments
YouTrack connector, issue's editor view (593.70 KB, application/octet-stream)
2014-02-21 07:27 EST, Alexander Marchuk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Marchuk CLA 2014-02-01 08:24:55 EST
YouTrack is issue tracker from JetBrains. I implement connector for Mylyn and 
ready for UI review.

Related resources:

-update site: http://jetbrains.github.io/youtrack.mylyn.connector/updatesite/update/

-public bugtracker:
http://nylym.myjetbrains.com/youtrack/ project "Mylyn Eclipse Plugin"

-information about plugin (later will be filled better):
http://jetbrains.github.io/youtrack.mylyn.connector/
Comment 1 Sam Davis CLA 2014-02-12 11:57:02 EST
Hi Alexander,

Here is the error I got when trying to install the connector on Eclipse 3.8:

Cannot complete the install because one or more required items could not be found.
  Software being installed: YouTrack Mylyn Connector 1.0.0.201402112032 (com.jetbrains.mylyn.yt.connector.feature.feature.group 1.0.0.201402112032)
  Missing requirement: YouTrack Mylyn Connector 1.0.0.201402112032 (com.jetbrains.mylyn.yt.connector.feature.feature.group 1.0.0.201402112032) requires 'org.apache.log4j 0.0.0' but it could not be found
Comment 2 Sam Davis CLA 2014-02-12 17:49:29 EST
Alexander, could you post a couple of screenshots of the task editor, one showing it in edit mode and one in read-only mode?
Comment 3 Alexander Marchuk CLA 2014-02-21 07:27:13 EST
Created attachment 240191 [details]
YouTrack connector, issue's editor view
Comment 4 Alexander Marchuk CLA 2014-02-21 07:36:26 EST
Hi Sam, 
sorry for a delay. Thank you for that serious bug. I add requested screenshots of issue editor views and fix dependency problem for last supported Eclipse release 3.8. 
Now expect your next suggestions.
Comment 5 Sam Davis CLA 2014-02-21 13:33:31 EST
Thanks for the screenshots. 

Here are some notes I made during the presentation:

* There are no task type icons. If the web UI uses different icons for each task type (e.g. task, feature), the connector should use the same icons in the task list.
* The custom query field in the query dialog is missing a border which looks funny.
* The title field should be above the custom query field in query dialog.
* Since there is no "clear outgoings" button, it seems you can't tell if the task has outgoing changes by looking at the task editor.
* Are fields with incoming changes highlighted in task editor? I don't think we saw that in the demo.
* Is there support for attachments or is this planned to be added? In particular, can you attach your context to a task?
* Instead of reimplementing the repository settings page, you should just reuse the standard one.

In general, I would suggest that you consider following the Mylyn conventions used by other connectors when there isn't a strong reason to deviate. For example, I would use the standard toolbar buttons instead of providing custom icons. This would provide a consistent UI for people using multiple connectors and ensure that changes and new features in Mylyn will also benefit the Youtrack connector rather than causing problems for it. Having a lot of custom UI in the connector, such as your custom attributes section, tends to make maintenance of the connector harder as the Mylyn framework evolves.
Comment 6 Alexander Marchuk CLA 2014-02-28 03:50:50 EST
Hello Sam,
it is not correct at all, that my connector has a lot of customization. In many existed cases I need to customize UI because of YouTrack's specific. Lets examine:
* There are no task type icons, because of YT don't have one
* Your notes about title field in query dialog and about missing border are correct, thank you
* Outgoings may be seen in Task List, not in editor
* Yes, fields with incoming changes highlighted with blue background
* I planned to add attachments support later, it is a really complicated task. Now users may use context attachment as usually in Mylyn
* I use standard repository settings with minor changes, but I will return to ordinary view
* For those actions, what I recognize like as the same, I use similar icons for toolbar buttons
* Using Browser widget in description and issue comment is reasonable
What do you mean when say about customization in attributes section? All editors here are just common mylyn editors.
I understand your suspicion about maintainance in future. But now in general, as I think, connector consists with Mylyn style and youtrack users experience. 
In extreme case, if it would be, you always may exclude connector from Discovery Listing.
Comment 7 Sam Davis CLA 2014-02-28 13:33:51 EST
(In reply to comment #6)
> * Outgoings may be seen in Task List, not in editor

This seems like an unnecessary limitation, since they would be visible in the task editor if you were not using a custom toolbar.

> What do you mean when say about customization in attributes section?

What I meant is that you have implemented your own attributes section with separate read/write modes instead of using the standard attributes section provided by Mylyn. It's good that incoming changes are still highlighted, though. I wonder how this works with the quick outline? In other task editors, when pressing Ctrl+O, the quick outline shows all attributes and selecting one opens its attribute editor.

> * Using Browser widget in description and issue comment is reasonable

I'm not sure what your comment about using a browser widget is in response to.

I understand that you want the connector UI to be consistent with the YouTrack web UI. I would just suggest that you try to avoid customizations that break Mylyn functionality and that you also try to maintain consistency with other connectors as much as possible.
Comment 8 Sam Davis CLA 2014-06-26 19:53:22 EDT
Alexander, do you still want to add the connector to Connector Discovery?
Comment 9 Alexander Marchuk CLA 2014-06-27 11:40:01 EDT
Hello Sam,
sorry for delay in response - I spend time over my exams and another project.

Yes, I still want to contribute to Connector Discovery. I don't not have so much time than earlier,, but will try to achieve this goal as hard as possible. As I see from our last discussion, I must implement outgoings view in editor and quick outline (as I remember it works, maybe not at all). This tasks will be my nearest work, but there are more serious and undefined issues:

>I would just suggest that you try to avoid customizations that break Mylyn functionality and that you also try to maintain consistency with other connectors as much as possible.

It will be good to review, what customization is unsufficient and come to agreement about changes. Ideally if I know all necessary work and may observe it.
Comment 10 Sam Davis CLA 2014-06-27 16:26:14 EDT
(In reply to comment #9)
> Hello Sam,
> sorry for delay in response - I spend time over my exams and another project.
> 
> Yes, I still want to contribute to Connector Discovery. I don't not have so much
> time than earlier,, but will try to achieve this goal as hard as possible. As I
> see from our last discussion, I must implement outgoings view in editor and
> quick outline (as I remember it works, maybe not at all). This tasks will be my
> nearest work, but there are more serious and undefined issues:

I enourage you to pursue those changes for the reasons I mentioned before, but I don't think they need to block adding the connector to discovery.

> 
> >I would just suggest that you try to avoid customizations that break Mylyn
> functionality and that you also try to maintain consistency with other
> connectors as much as possible.
> 
> It will be good to review, what customization is unsufficient and come to
> agreement about changes. Ideally if I know all necessary work and may observe
> it.

For example, the custom task editor toolbar that uses different icons and buttons than the standard Mylyn toolbar.

Please feel free to push a review to Gerrit adding the connector to discovery. For an example of what to do, you can look at https://git.eclipse.org/r/#/c/27299/ which added the Tuleap connector to discovery. Let me know if you have any questions.
Comment 11 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn