Community
Participate
Working Groups
What is the preferred way to integrate the dark theme from org.eclipse.ui.e4.themes into the Eclipse SDK? Should it be added to the org.eclipse.e4.rcp feature?
How do you plan to fix the Menu & Button & Table & Tree problem where you are unable to set a background - I see this as a strong requirement before we provide such a theme by default
(In reply to Thomas Schindl from comment #1) > How do you plan to fix the Menu & Button & Table & Tree problem where you > are unable to set a background - I see this as a strong requirement before > we provide such a theme by default The idea is that a default dark theme helps us to promote issues and that we get more contributions. For example after I announced that I work on a dark theme, Tony McCrary draw more than 600 svg graphics and a svg to png converter to make the dark theme look better. I also hope that your work with SWT on JavaFX and the GTK3 migration on Linux might help to solve some of these issue. And the contributed dark looks already awesome on Ubuntu with Unity (Buttons can be styled, menu hidden) and I heard that it also looks great on Mac (have only seen screenshots).
You can throw away Eclipse CSS if we succeed with SWT on JavaFX ;-) - the real issue BTW is not Linux - the real blocker is win32 - and sorry to say this is still the biggest user base.
This blog post talks about the issues in implementing a dark theme in Visual Studio and there's 3 screenshots showing the evolution of theme as it nears release: http://blogs.msdn.com/b/visualstudio/archive/2012/05/29/visual-studio-dark-theme.aspx The first screenshot, marked as BETA, is pretty much doable with CSS alone and is where we're at now. The second one, marked Release Candidate, is still doable by changing how SWT is called to open the Shells for workbench windows. It's the third one, marked Release To Manufacturing, which implements dark scrollbars and is where the problems are. Doing that one may require changing the SWT implementation itself.
As suggested by Paul, this Gerrit reviews add it to the "org.eclipse.platform-feature". https://git.eclipse.org/r/21623
(In reply to Lars Vogel from comment #5) > As suggested by Paul, this Gerrit reviews add it to the > "org.eclipse.platform-feature". > > https://git.eclipse.org/r/21623 Released as http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=ba128f8fb3b77821d581d29a9d7fcbd176e3bff5 Lars, will this need to be a directory-shaped plugin? PW
(In reply to Paul Webster from comment #6) > Lars, will this need to be a directory-shaped plugin? What is a directory-shaped plugin? I definitely need the plugin.xml to register the theme.
(In reply to Lars Vogel from comment #7) A bundle with "Bundle-shape: dir" directive in the manifest. It will unpack the jar into a directory in the plugins directory.
(In reply to Wim Jongman from comment #8) > (In reply to Lars Vogel from comment #7) > > A bundle with "Bundle-shape: dir" directive in the manifest. It will unpack > the jar into a directory in the plugins directory. Thanks Wim. Why would I use this / what advantages has this?
(In reply to Lars Vogel from comment #9) Sometimes files cannot be retrieved from a jar (e.g. css files)
(In reply to Wim Jongman from comment #10) > (In reply to Lars Vogel from comment #9) > > Sometimes files cannot be retrieved from a jar (e.g. css files) Thanks. Didn't know that. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d5162b124368280dd16f1ef2cd147baec8b21839 I think the feature should also be adjusted, flag "Unpack the plug-in archive after the installation". Paul, I cannot commit to releng, please have a look. https://git.eclipse.org/r/21873
(In reply to Lars Vogel from comment #11) > > I think the feature should also be adjusted, flag "Unpack the plug-in > > https://git.eclipse.org/r/21873 I think that is not considered when building with Tycho. However, it will not harm.
Paul, confirmed that http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d5162b124368280dd16f1ef2cd147baec8b21839 is the correct fix. Thanks Wim and Paul for the help.
Correction, Paul said it should be "Eclipse-BundleShape: dir", I have a typo in the commit, I fix that.
Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=675d6c5c2eb787790517cfcf80bcb1f43f525d54
Verified in N20140212-2000
How to check that the current theme is black/inverted? Some values like font color, should not be set to black. Please check issue Bug 425646 - [Themes] Support for black and inverted color UI themes.
