Community
Participate
Working Groups
Scenario: 1. In a fresh workspace open Project Explorer. -> view menu disappears immediately after opening the view 2. Minimize and then restore the view -> view menu is visible 3. Create a java project. 4. In Project Explorer unfold the content of the project and select any item -> view menu disappears again. Found in Eclipse 4.3.2 M20140129-0800. I cannot reproduce the bug in 4.4 M5 and 4.3.1.
May be related to the bug 420902.
Wojtek and Daniel, could you please investigate this on Monday to see if we can find the cause? I'd like to see if we could fix this before 4.3.2 goes out with this problem. Thanks, Paul
The bug has been introduced in the commit 59b0576c7c3f0152436fe38a24bc456b42c84231 (Fix for Bug 416650 - CTabFolder layouts content too often / too many of them). Fix review URL: https://git.eclipse.org/r/#/c/21433/ .
Eric, could you please take a look at this fix? PW
Wojciech, good pickup ! Unfortunately the patch may fix the defect but breaks the original performance fix in doing so... Can you investigate *why* the view menu disappears ? Since it doesn't happen (I hope) for the Package Explorer I suspect that there's some extra logic used by the Project Explorer in managing its menu ? This may also be a painting bug; I seem to remember a case where the 'pack' call wasn't actually changing the size of the control it wasn't being repainted...
If instead of layout out the whole CTF you just layout the 'trComp' it seems to work...I just added 'trComp.layout(true, true);' after the 'trComp.pack()' call at line 673 in the StackRenderer and it seems to work ok, could you check this out for me. I'd still be interested in why the Project Explorer's behavior is different than the Package Exploter's though...;-).
I have update the code and it still does fix the bug.
It seems that this is a duplicate of Bug 417960 - "[EditorMgmt] History view dropdown menu disappears" that is already fixed in 4.4. Since it is not a small fix, should we port it to 4.3?
Dani, I'd like to consider this bug for 4.3.2 RC3. Having the view menu disappear in SR2 I think is pretty major (even though you can get it back) and I think the fix is safe. PW
(In reply to Wojciech Sudol from comment #8) > It seems that this is a duplicate of Bug 417960 - "[EditorMgmt] History view > dropdown menu disappears" that is already fixed in 4.4. > Since it is not a small fix, should we port it to 4.3? I verified that the proposed fix also fixes bug 417960 in 4.3.2 and hence it's the best fix at this point since it is too risky so late in the game for the "bug" fix. Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7de46ea4313cf06e21313f752f63f9e42ba8bace
Verified in M20140205-0800.
