This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 427108 - Context created for MDynamicMenuContribution processing should be disposed
Summary: Context created for MDynamicMenuContribution processing should be disposed
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Mac OS X
: P3 major (vote)
Target Milestone: 4.3.2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 426828
Blocks:
  Show dependency tree
 
Reported: 2014-01-31 06:29 EST by Paul Webster CLA
Modified: 2015-04-30 08:52 EDT (History)
5 users (show)

See Also:
daniel_megert: pmc_approved+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2014-01-31 06:29:59 EST 
I'd like to consider patching this back to 4.3.2, as it's a context leak tied to opening and closing menus.


+++ This bug was initially created as a clone of Bug #426828 +++

Currently a IEclipseContext is created but not disposed:
* MenuManagerShowProcessor#processDynamicElements
* MenuManagerHideProcessor#processDynamicElements
Comment 1 Nobody - feel free to take it CLA 2014-01-31 07:45:47 EST 
Do you need a separate gerrit for this one?
Comment 2 Paul Webster CLA 2014-01-31 09:03:38 EST 
(In reply to Sopot Cela from comment #1)
> Do you need a separate gerrit for this one?

Thanks, but once we fix the original one I'll cherry-pick it over for review.

PW
Comment 3 Paul Webster CLA 2014-01-31 09:24:22 EST 
A 4.3.2 patch for review. https://git.eclipse.org/r/21388

Paul, could you please review it, but don't merge it when you are done.

Thanks
PW
Comment 5 Dani Megert CLA 2014-02-05 12:19:57 EST 
Verified in source of M20140205-0800.