426828 – Context created for MDynamicMenuContribution processing should be disposed

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 426828 - Context created for MDynamicMenuContribution processing should be disposed

Summary: Context created for MDynamicMenuContribution processing should be disposed

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.4
Hardware:	PC Mac OS X

Importance:	P3 major (vote)
Target Milestone:	4.4 M6
Assignee:	Paul Webster
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	427108
	Show dependency tree

Reported:	2014-01-28 13:43 EST by Thomas Schindl
Modified:	2014-03-04 12:42 EST (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Thomas Schindl

2014-01-28 13:43:51 EST

Currently a IEclipseContext is created but not disposed:
* MenuManagerShowProcessor#processDynamicElements
* MenuManagerHideProcessor#processDynamicElements

Comment 1 Nobody - feel free to take it

2014-01-30 09:17:28 EST

 https://git.eclipse.org/r/21330

Comment 2 Lars Vogel

2014-01-30 17:53:23 EST

Thanks Sopot. Your change looks OK to me. 

Tom, can you review it and approve it?

Comment 3 Paul Webster

2014-01-31 09:05:31 EST

Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=681f84722d5aabfcd8e944c3709dfed200f464aa

Thanks Sopot,

PW

Comment 4 Paul Webster

2014-03-04 12:42:05 EST

In 4.4.0.I20140303-2000

PW