Community
Participate
Working Groups
With Bug 423813 fixed, maybe we can remove the warning popup which is displayed if a theme is changed?
After reading https://bugs.eclipse.org/bugs/show_bug.cgi?id=423813#c14 it looks like the restart is still required. Maybe we can display a warning message on the preference page instead of the popup? I find the popup a bit too strong, especially as now most of the CSS seems to get applied at runtime.
(In reply to Lars Vogel from comment #1) > After reading https://bugs.eclipse.org/bugs/show_bug.cgi?id=423813#c14 it > looks like the restart is still required. > > Maybe we can display a warning message on the preference page instead of the > popup? I find the popup a bit too strong, especially as now most of the CSS > seems to get applied at runtime. It is good idea, Daniel
I'm fine as long as the warning appears when the change is made and is close to the combo that drives the change. PW
AFAIK for some widgets the restart is still required. The problem in 4.x (as compared to 3.x) is that the dialog no longer directly allows to restart. So, first we should double-check on the "required". If it is required, then we should keep the dialog but make it again work like in 3.x.
(In reply to Dani Megert from comment #4) > AFAIK for some widgets the restart is still required. The problem in 4.x (as > compared to 3.x) is that the dialog no longer directly allows to restart. > > So, first we should double-check on the "required". If it is required, then > we should keep the dialog but make it again work like in 3.x. Sounds like a bit of overdesign IMHO. The popup is relative annoying, especially as it is displayed twice (press Apply and afterwards OK). A inline warning would be already a big improvement to the popup.
I just learned from Daniel in IRC that he manually resets all SWT widgets and that a missing reset would be considered a bug. In this case I think a label in the dialog would be sufficient.
Sopot, do you want to take this one? I originally implemented the popup.
Yes I can take it. So what's the consensus on the location of the label?
Created attachment 240902 [details] Screenshot What about this amazing mockup? Button should of course be pushed done...
I'll try to implement it somehow and I'll post screenshots.
Created attachment 241203 [details] Proposed visual solution I like this one better because it is closer to the action. Give me a go and I'll push the gerrit.
Just in case: https://git.eclipse.org/r/23825
Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a7e66ff93fa8ca612f1bb3d1598ec2ce9fd407f6 Thanks Sopot!
(In reply to Lars Vogel from comment #13) > Fixed with > https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=a7e66ff93fa8ca612f1bb3d1598ec2ce9fd407f6 > > Thanks Sopot! The 'Restart is required ...' message was also applicable for the 3.x theme combo (if (themeChanged || colorsAndFontsThemeChanged)). Does the new popup support the 3.x combo as well? Daniel
(In reply to Daniel Rolka from comment #14) > The 'Restart is required ...' message was also applicable for the 3.x theme > combo (if (themeChanged || colorsAndFontsThemeChanged)). Does the new popup > support the 3.x combo as well? Does this require also sometimes a restart? In this case if would be great if Sopot can add a similar warning message to the second combo.
(In reply to Lars Vogel from comment #15) > (In reply to Daniel Rolka from comment #14) > > > The 'Restart is required ...' message was also applicable for the 3.x theme > > combo (if (themeChanged || colorsAndFontsThemeChanged)). Does the new popup > > support the 3.x combo as well? > > Does this require also sometimes a restart? In this case if would be great > if Sopot can add a similar warning message to the second combo. Yes, I would add the similar popup for the 3.x theme combo thanks, Daniel
Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=478fb6533dd6fe68c91b8a98fe978114f0c30581
Verified in Build id: I20140427-2030
This is not really nice as it requires user work to figure out what's going on. Take a look at the 'Compiler' preference page and change the compliance to e.g. '1.3'. This will show a warning and give enough information for the user to decide what to do. For this bug here it could show a link to restart the workbench.
