Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 426634 - remove 3rd party bundles from master-equinox feature
Summary: remove 3rd party bundles from master-equinox feature
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.3.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M6   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 406825
  Show dependency tree
 
Reported: 2014-01-25 00:23 EST by David Williams CLA
Modified: 2014-01-25 10:34 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-01-25 00:23:39 EST 
As a small step to get rid of "master features", I think we can probably remove all the "third party" bundles from master-equinox feature. 

Below is current list. These were needed for PDE builds so there would be something to "fetch" the bundles before they were needed ... but Tycho/Maven does that on its own, based on manifest.mf files (and target execution file) so no need to be redundant. 

There are a few cases, where component poms might have to be changed ... but, that's unlikely. I will of course do investigations and test builds to determine ... but might hope is these can simply be removed. (This came to my attention recently looking closely at bug 426070 and realizing that "mina.core" did not need to be in this master-equinox feature). 

                                    
    <plugin
         id="javax.servlet"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"/>        
     
    <plugin
         id="javax.el"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"/> 
        
    <plugin
         id="org.apache.commons.logging"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"/>        

    <plugin
         id="org.apache.felix.gogo.runtime"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"/>      
      
   <plugin
         id="org.slf4j.api"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"/>       
         
    <plugin
         id="org.apache.mina.core"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"/> 
      
    <plugin
         id="org.apache.sshd.core"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"/>
         
     <plugin
         id="org.apache.jasper.glassfish"
         download-size="0"
         install-size="0"
         version="0.0.0"
         unpack="false"/>
Comment 1 David Williams CLA 2014-01-25 10:34:21 EST 
http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=034e2a3aa3c96c3683b919b2d2cd8e2115684b77

In a local test build, the build still succeeded, so I think worth putting in today's "nightly" and can better see if it makes any difference in tests or repository contents, etc. 

I did do searches and each bundle seemed to be included in some other feature, so I do not think required in this 'master feature' when using Tycho/Maven, and will make no difference to final output.  

Removing these as one step, will make it easier to decide what to do with the remaining items. Many can likely just be removed also, and those that can't, can probably be safely "moved up" to the one 'master feature' as another step to getting rid of all master features.