This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 426572 - [CSS] CSS does not work with Eclipse 4.4
Summary: [CSS] CSS does not work with Eclipse 4.4
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 major with 1 vote (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Daniel Rolka CLA
QA Contact: Daniel Rolka CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-24 07:56 EST by Paul Seibt CLA
Modified: 2014-03-04 09:36 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Seibt CLA 2014-01-24 07:56:12 EST 
My CSS-File works fine with Eclipse 4.3.1 but not with 4.4.

The used CSS-file is pretty simple:

Label {
	font: Verdana 8px;
	color: red;
}

Text {
	font: Verdana 12px;
}
Comment 1 Paul Seibt CLA 2014-01-24 08:12:50 EST 
My plugin.xml:

<plugin>

   <extension
         id="product"
         point="org.eclipse.core.runtime.products">
      <product
            application="org.eclipse.e4.ui.workbench.swt.E4Application"
            name="to-do">
         <property
               name="appName"
               value="to-do">
         </property>
         <property
               name="lifeCycleURI"
               value="bundleclass://com.example.e4.rcp.todo/com.example.e4.rcp.todo.lifecycle.Manager">
         </property>
         <property
               name="applicationCSS"
               value="platform:/plugin/com.example.e4.rcp.todo/css/default.css">
         </property>
      </product>
   </extension>

</plugin>
Comment 2 Paul Webster CLA 2014-01-24 08:53:27 EST 
Please provide a simple plugin that can be launched so we can see the problem.

Do you see any errors with your error log?  <runtime_workspace>/.metadata/.log or by running your app with -consoleLog

PW
Comment 3 Daniel Rolka CLA 2014-01-24 10:26:26 EST 
It seems to be the regression introduced by the Bug 355010 - see the comment #22

As the temporary workaround for the issue please use the 'cssTheme' property instead of, like below:

<plugin>
   <extension
         id="product"
         point="org.eclipse.core.runtime.products">
      <product
            name="RCP4"
            application="org.eclipse.e4.ui.workbench.swt.E4Application">
         <property
               name="cssTheme"
               value="default.theme.id">
         </property>
         <property
               name="appName"
               value="RCP4">
         </property>
      </product>   
   </extension>
   <extension point="org.eclipse.e4.ui.css.swt.theme">
      <theme
            basestylesheeturi="css/default.css"
            id="default.theme.id"
            label="Default Theme">
      </theme>
   </extension>
</plugin>

It will be fixed with the Bug 355010,
Daniel
Comment 4 Lars Vogel CLA 2014-01-24 13:00:20 EST 
Shall we mark this one as duplicate of Bug 355010?
Comment 5 Paul Webster CLA 2014-01-24 13:04:06 EST 
This is an appropriate bug to fix the usecase in M6.  We can make this block any other bug.

PW
Comment 6 Daniel Rolka CLA 2014-01-27 05:06:53 EST 
I'm not sure if we should mark it as 'critical' since there is the workaround for the issue (see Comment 3). I think the 'major' priority is better for it

Daniel
Comment 7 Lars Vogel CLA 2014-01-27 05:12:49 EST 
(In reply to Daniel Rolka from comment #6)
> I'm not sure if we should mark it as 'critical' since there is the
> workaround for the issue (see Comment 3). I think the 'major' priority is
> better for it

Thanks, changed.
Comment 8 Daniel Rolka CLA 2014-01-27 06:13:28 EST 
I've pushed the patch to Gerrit that fixes the regression: https://git.eclipse.org/r/#/c/21127/

We can skip the bug 355010 opened if we need to change sth in the current implementation or close it when it is all what we wanted to have,

Daniel
Comment 10 Daniel Rolka CLA 2014-03-04 09:36:42 EST 
Verified in the build: I20140303-2000

Daniel