Community
Participate
Working Groups
We noticed that the Gerrit starred flag is not handled within the Mylyn Gerrit connector. This functionality is required for the Eclipse Gerrit Dashboard found under the Mylyn Review.
+1 Please note that there is related discussion on bug 413917 already. Sound like you are planning to extend the core initially so it makes sense to me to track this on a different bug.
Code to handle the starred flag from org.eclipse.mylyn.gerrit.core Gerrit review: https://git.eclipse.org/r/#/c/21916/
Hi Steffen, I looked at your comments on Gerrit fo this bug and one of them talk about using the REST API (File: GerritHttpClient.java) It seems to me that when I used the new method to use HttpPut() and HttpDelete() method. it works fine. When I try to create a new HttpMethodBase.createmethod (PUT and DELETE), I always get an error: 400, 401 or 403. This seems related to the authentication. I cannot find how you process the authentication which would validate the method and process the command on the Gerrit server. On Gerrit 2.8, the command : STAR/UNSTAR uses the new REST API wihich require PUT/DELETE commands. When testing on Gerrit 2.7 and before, the commands work fine and use POST command. Do you have any idea why ?
Push new code for a review. Fix all comments from patch set 1 review: https://git.eclipse.org/r/#/c/21916/
Just rebase to the latest Mylyn review Gerrit review: https://git.eclipse.org/r/#/c/21916/ If there is no more comments, I should push it on April 3
Adressed all comments on version 8 Gerrit Review: https://git.eclipse.org/r/#/c/21916/
- Unit test added, rebase on April 10 - All comment were fixed. Should be merged unless you have other comments Gerrit: https://git.eclipse.org/r/#/c/21916/
-Code reviewed and rebased as of April 21, - Code pushed to the master ranch
