Community
Participate
Working Groups
Bug 424489 introduced an alternative to the existing min/max concept. This bug captures the ongoing discussions and improvements for this feature.
From Markus Keller, bug 424489 comment #17: - Toggling "Use Overlays" doesn't toggle an already-opened fast view. - It's a bit strange that the "Use Overlays" popup menu is only on the "Restore" button. The setting doesn't affect the "Restore" button. It affects the behavior of the hidden parts buttons, and it makes their "Orientation" popup menu choices pointless.
> - It's a bit strange that the "Use Overlays" popup menu is only on the > "Restore" button. The setting doesn't affect the "Restore" button. It > affects the behavior of the hidden parts buttons, and it makes their > "Orientation" popup menu choices pointless. We could put the menu item into the menu of each view icon, and synchronize the state for now. Maybe later, we could even set this per view? This should also make it easier to remove the 'Orientation' menu when in the new mode. Also, "Overlays" sounds a bit technical. How about: Show at Original Location I think some people might like this new mode, but I'm not sure whether making it the default is good though. Problems I encountered when using it: - The iew no longer open close to the icon. In cases where I longer know the original place, it looks like it opens at some random place. - The workbench relayouts to make place for the stack. Sometimes this is quite noisy and heavyweight, especially when one only wants to quickly glance at a view (that's why we called them fast views ;-).
Moving back to Eric. I think it makes sense if he finishes this.
Thanks guys, this is indeed good input. I really like the idea of eventually being able to make this per view since only a small subset of views get shown automatically and obscure the editor (Console, Debug, Search...). BTW, I've been using it for some time and while it's certainly OK for most things you can really get hosed by the new mode: 1) Maximize an editor in the Debug perspective 2) activate the Debug view (with Use Overlays off) 3) Now try to double-click to place a break point What happens is that the first click activates the editor -> the Debug view gets torn down -> the layout changes and we end up on the wrong lines of code !
Committed: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fc0154a1369c6824aa0bcc8a324ba93d3462ea8e This changes the menu item's text to 'Show in the original location' as well as making the show 'mode' stack based. I'm going to continue to work some more on this to see if I can arrange that the MINIMIZED_BY_ZOOM state can be maintained across a 'Restore'. This would allow users to actually restore the stack for as long as they want then minimize it again *without* having the stack not auto-restore on the unmax as it currently does...
Committed: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7c113f7d02a9990ade430399112e7b39b2d394c9 This maintains the 'MINIMIZED_BY_ZOOM' state until an actual 'unzoom' is performed, regardless of whether the stack is restored in the interim.
Verified in 4.4.0.I20140428-2000.
