Community
Participate
Working Groups
I noticed at a customer Windows7 machine that the difference between the enabled / disabled status of the save icon is almost not recognizable. Is this an issue with the new png file, or has this always been the case in Eclipse 4.x with the Windows7 theming? I personally don't have a Windows7 system so I cannot check that.
Created attachment 239255 [details] Picture with enabled and disabled save icons It's indeed very hard to see a difference (disabled above, enabled below).
We should try to get better icons for M5 or switch back to GIF. Lars, can you take care of this?
(In reply to Dani Megert from comment #1) > Created attachment 239255 [details] > Picture with enabled and disabled save icons > > It's indeed very hard to see a difference (disabled above, enabled below). Can you attach a screenshot with the old icons on Windows7? Is that better?
(In reply to Dani Megert from comment #2) > We should try to get better icons for M5 or switch back to GIF. > > Lars, can you take care of this? Yes, I try to get a better icon from Tony and this does not work until tonight CET, I switch the save icon back to the .gif one (if that is better, don't know that, from looking at the Gif, it looks very similar).
Created attachment 239256 [details] GIFs (from M4)
(In reply to Lars Vogel from comment #4) > Yes, I try to get a better icon from Tony and this does not work until > tonight CET, I switch the save icon back to the .gif one (if that is better, > don't know that, from looking at the Gif, it looks very similar). So far, there's no further build scheduled. We'll either have to ask for a rebuild (the sooner the better) or catch a rebuild requested by another component.
(In reply to Dani Megert from comment #6) > (In reply to Lars Vogel from comment #4) > > Yes, I try to get a better icon from Tony and this does not work until > > tonight CET, I switch the save icon back to the .gif one (if that is better, > > don't know that, from looking at the Gif, it looks very similar). > > So far, there's no further build scheduled. We'll either have to ask for a > rebuild (the sooner the better) or catch a rebuild requested by another > component. To me, the disabled version looks pretty similar to the gif icon but I can have the filter lighten it up a bit more. The disabled icon is generated from the default rendered PNG (it applies a desaturation process to make it look greyed out). It should be pretty trivial to have the renderer make the icon lighter.
Created attachment 239262 [details] Lightened Test Icons
(In reply to Tony McCrary from comment #8) > Created attachment 239262 [details] > Lightened Test Icons I've attached some new icons that were rendered with some tweaks to the HSB filter. Let me know if you find these contrast the default icon state more.
Dani, could you please test the change on Windows7? Looks still fine on Linux to me. https://git.eclipse.org/r/20991
Created attachment 239269 [details] Picture of new save icons (In reply to Lars Vogel from comment #10) > Dani, could you please test the change on Windows7? Looks still fine on > Linux to me. > > https://git.eclipse.org/r/20991 Now it almost looks white. It's too aggressive for a disabled icon.
Created attachment 239271 [details] Picture of new save icons
I assume that once we have a good disabled save icon, you're going to resubmit all disabled icons with the same coloring scheme, right? Maybe for now, we just switch those two back to GIFs for M5?
(In reply to Dani Megert from comment #13) > I assume that once we have a good disabled save icon, you're going to > resubmit all disabled icons with the same coloring scheme, right? > > Maybe for now, we just switch those two back to GIFs for M5? Will do, in approx. one hour.
(In reply to Lars Vogel from comment #14) > (In reply to Dani Megert from comment #13) > > Maybe for now, we just switch those two back to GIFs for M5? This change SHOULD IMHO switch back to use the old gif but if I start my runtime workbench, I still see the old png files. If I did something obviously stupid, let me know I continue to investigate why I see the png icons. https://git.eclipse.org/r/21004
(In reply to Lars Vogel from comment #15) > (In reply to Lars Vogel from comment #14) > > (In reply to Dani Megert from comment #13) https://git.eclipse.org/r/21004 Change works for me, I don't dare to commit to master, as I can't say how important this is. Dani, please apply to master and ask for a respin if that is important enough.
(In reply to Lars Vogel from comment #16) > (In reply to Lars Vogel from comment #15) > > (In reply to Lars Vogel from comment #14) > > > (In reply to Dani Megert from comment #13) > > https://git.eclipse.org/r/21004 > > Change works for me, Yes, the change is (almost) good. See my comment in Gerrit. > I don't dare to commit to master, as I can't say how > important this is. Dani, please apply to master and ask for a respin if that > is important enough. There will be a respin request from Platform UI for some other fixes. If I look at the icon, it's not just the coloring that's wrong. It also looks strange, like some rabbit teeth ;-).
(In reply to Dani Megert from comment #17) > (In reply to Lars Vogel from comment #16) > > (In reply to Lars Vogel from comment #15) > > > (In reply to Lars Vogel from comment #14) > > > > (In reply to Dani Megert from comment #13) > > > > https://git.eclipse.org/r/21004 > > > > Change works for me, > > Yes, the change is (almost) good. See my comment in Gerrit. > > > I don't dare to commit to master, as I can't say how > > important this is. Dani, please apply to master and ask for a respin if that > > is important enough. > > There will be a respin request from Platform UI for some other fixes. > > > If I look at the icon, it's not just the coloring that's wrong. It also > looks strange, like some rabbit teeth ;-). Yes, it's a memory card not a floppy disk. Memory cards have little metal "teeth" instead of a door that slides open.
Created attachment 239280 [details] Fixed "decontrast" icon processing example I've attached an example of a new process for creating the disabled icons. This includes a step that deliberately eliminates contrast, in addition to the HSB color processing. I've carefully compared the output to the existing disabled gifs and I think this looks very close. On the top, the left icon is the disabled gif, the middle is the icon created with the new process and the right is the old disabled icon.
Created attachment 239281 [details] "decontrasted" icons This attachment has the icons themselves, if you want to try them out.
(In reply to Lars Vogel from comment #16) > (In reply to Lars Vogel from comment #15) > > (In reply to Lars Vogel from comment #14) > > > (In reply to Dani Megert from comment #13) > > https://git.eclipse.org/r/21004 Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c709d03ad2a84cc2ca7a78f9e9c0546c6cd0727f
(In reply to Tony McCrary from comment #18) > > If I look at the icon, it's not just the coloring that's wrong. It also > > looks strange, like some rabbit teeth ;-). > > Yes, it's a memory card not a floppy disk. Memory cards have little metal > "teeth" instead of a door that slides open. I can't speak of other platforms but on Windows the floppy is still the icon that's used in almost all applications. The current icon is just confusing.
(In reply to Dani Megert from comment #22) > (In reply to Tony McCrary from comment #18) > > > If I look at the icon, it's not just the coloring that's wrong. It also > > > looks strange, like some rabbit teeth ;-). > > > > Yes, it's a memory card not a floppy disk. Memory cards have little metal > > "teeth" instead of a door that slides open. > > I can't speak of other platforms but on Windows the floppy is still the icon > that's used in almost all applications. The current icon is just confusing. I fail to see what's confusing about it, it keeps the exact same metrics as a floppy disk (this was done on purpose, to avoid confusion). I'm willing to bet if it wasn't pointed out, you wouldn't have noticed the difference.
(In reply to Tony McCrary from comment #23) > (In reply to Dani Megert from comment #22) > > (In reply to Tony McCrary from comment #18) > > > > If I look at the icon, it's not just the coloring that's wrong. It also > > > > looks strange, like some rabbit teeth ;-). > > > > > > Yes, it's a memory card not a floppy disk. Memory cards have little metal > > > "teeth" instead of a door that slides open. > > > > I can't speak of other platforms but on Windows the floppy is still the icon > > that's used in almost all applications. The current icon is just confusing. > > I fail to see what's confusing about it, it keeps the exact same metrics as > a floppy disk (this was done on purpose, to avoid confusion). It just makes no sense to use a different icon/concept than every other application on the (Windows) platform. > I'm willing to bet if it wasn't pointed out, you wouldn't have noticed the > difference. Well *I* pointed it out ;-).
(In reply to Dani Megert from comment #24) > (In reply to Tony McCrary from comment #23) > > (In reply to Dani Megert from comment #22) > > > (In reply to Tony McCrary from comment #18) > > > > > If I look at the icon, it's not just the coloring that's wrong. It also > > > > > looks strange, like some rabbit teeth ;-). > > > > > > > > Yes, it's a memory card not a floppy disk. Memory cards have little metal > > > > "teeth" instead of a door that slides open. > > > > > > I can't speak of other platforms but on Windows the floppy is still the icon > > > that's used in almost all applications. The current icon is just confusing. > > > > I fail to see what's confusing about it, it keeps the exact same metrics as > > a floppy disk (this was done on purpose, to avoid confusion). > > It just makes no sense to use a different icon/concept than every other > application on the (Windows) platform. > > > > I'm willing to bet if it wasn't pointed out, you wouldn't have noticed the > > difference. > > Well *I* pointed it out ;-). It's not a different concept at all. You pointed out the *floppy* looks slightly different, not that you didn't recognize it.
(In reply to Tony McCrary from comment #25) > It's not a different concept at all. It's a different icon than used in all other Windows apps. We won't change that.
(In reply to Dani Megert from comment #26) > (In reply to Tony McCrary from comment #25) > > It's not a different concept at all. > > It's a different icon than used in all other Windows apps. We won't change > that. Okay then.
(In reply to Tony McCrary from comment #27) Tony provided an improved filter in the png, which looks really good to me. Thanks! Applied with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=935a9a8d14eec1ce5acddb4e50098637f8aeb2bc I update the save icon soon.
To regenerated the png icons I had to restore the pom.xml in org.eclipse.ui.images with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=07898e0f65269ef5fd8d1eb45cd3ebca12c5b443
Uploaded the newly generated png files with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6871852a26be13e8f32f60a51c8dcdcdbb88c503
This restores the floppy disk as default save icon in org.eclipse.ui.images http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ed9738f0540bdea52457c8a99638d77204388b54
Update of the png icons in org.eclipse.ui with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=dc7ea11480f1f7c1026a913737326284c9a38166 and usage of the png files again with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2a18688b7543415b0b8f7728168174fb44d0dd3b
New save icon contrast looks good in Build id: I20140303-2000, also on Windows
Verified in I20140427-2030.
