Community
Participate
Working Groups
Several GIF icons in PDE UI are missing their PNG counterparts. The first twenty or so icons in "icons/obj16" for instance (e.g. "alert_obj.gif", "all_sc_obj.gif", "att_boolean.gif"...). Additionally there are some folders which are missing completely: "dtool16", "etool16", "eview16" and "wizban").
I think we have also some missing icons for JDT UI. /icons/full/ovr16/java_ovr.png /icons/full/obj16/jcu_obj.png /icons/full/obj16/classf_obj.png /icons/full/obj16/jsearch_obj.png /icons/full/obj16/jworkingSet_obj.png /icons/full/obj16/java_model_obj.png
@Tony, could you please have a look?
(In reply to Lars Vogel from comment #2) > @Tony, could you please have a look? I'll check it out. I know there are still few icons that aren't perfectly aligned to pixels causing a blurry effect, specifically in PDE.
(In reply to Tony McCrary from comment #3) > (In reply to Lars Vogel from comment #2) > > @Tony, could you please have a look? > > I'll check it out. I know there are still few icons that aren't perfectly > aligned to pixels causing a blurry effect, specifically in PDE. Okay, the PDE icons do appear to be missing. The JDT icons specified do seem to exist on the google code site, so I guess we just missed some during the initial contribution: https://code.google.com/p/eclipse-svg-icons/ It's possible that there's an issue rendering to PNG, the error handling isn't extremely robust. However, I don't recall any errors on the current set hosted by eclipse.org. I will get working on the PDE icons, sorry about that. If any other JDT icons end up missing let me know. Also if you notice any icons that need some work (blurry, looks wrong, etc) let me know.
I found a typo in an icon from eclipse.debug.ui Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=dce1b1516eab604b02e698e6ac1cfc3ce10bfea6
(In reply to Tony McCrary from comment #4) > The JDT icons specified do seem to exist on the google code site, so I guess > we just missed some during the initial contribution: > https://code.google.com/p/eclipse-svg-icons/ It's possible that there's an > issue rendering to PNG, the error handling isn't extremely robust. However, > I don't recall any errors on the current set hosted by eclipse.org. Looks like the following folders are missing in the Eclipse repo. /git/eclipse-svg-icons/src/main/resources/eclipse.jdt.ui/org.eclipse.jdt.ui/icons/full/ovr16 I now included them into the Eclipse repo, assuming that these are the most recent versions. I think wizban icons are already png files in jdt.ui which is probably why you did not create svg versions, correct?
This review adds the missing icons, I have to wait until master is open again to apply it. https://git.eclipse.org/r/#/c/20862/
(In reply to Lars Vogel from comment #7) > This review adds the missing icons, I have to wait until master is open > again to apply it. > > https://git.eclipse.org/r/#/c/20862/ Applied with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4d5dee2b51e5f04f33e7b3134bc818d6e977b3c7
More missing JDT icons, this time I really wait until master is open again. ;-) https://git.eclipse.org/r/20863
(In reply to Tony McCrary from comment #4) > > Okay, the PDE icons do appear to be missing. > I will get working on the PDE icons, sorry about that. If any other JDT > icons end up missing let me know. Any news Tony on the PDE icons?
(In reply to Lars Vogel from comment #10) > (In reply to Tony McCrary from comment #4) > > > > > Okay, the PDE icons do appear to be missing. > > > I will get working on the PDE icons, sorry about that. If any other JDT > > icons end up missing let me know. > > Any news Tony on the PDE icons? I'm on the last 10%. I will make an effort to get them ready for the end of the week.
(In reply to Tony McCrary from comment #11) > (In reply to Lars Vogel from comment #10) > > (In reply to Tony McCrary from comment #4) > > > > > > > > Okay, the PDE icons do appear to be missing. > > > > > I will get working on the PDE icons, sorry about that. If any other JDT > > > icons end up missing let me know. > > > > Any news Tony on the PDE icons? > > I'm on the last 10%. I will make an effort to get them ready for the end of > the week. I'm afraid I'm a bit behind schedule with this. I will update the ticket when the new icons are ready.
(In reply to Tony McCrary from comment #12) > I'm afraid I'm a bit behind schedule with this. I will update the ticket > when the new icons are ready. Any update Tony?
(In reply to Lars Vogel from comment #9) > More missing JDT icons, this time I really wait until master is open again. > ;-) > > https://git.eclipse.org/r/20863 Looks like I forgot to commit this.
With https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e6f14488aed067af2e81279b4885ca5d0fdebf69 I mark this one as fixed. If we find more missing icons I open new bugs.
.
Change is visible in Git repo, marking as verified
