This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 426019 - [KeyBindings] Ctrl+F in Browser widget in a dialog is wrongly forwarded to workbench window
Summary: [KeyBindings] Ctrl+F in Browser widget in a dialog is wrongly forwarded to wo...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3.2   Edit
Assignee: Paul Elder CLA
QA Contact: Paul Elder CLA
URL:
Whiteboard:
Keywords:
Depends on: 412001
Blocks:
  Show dependency tree
 
Reported: 2014-01-17 14:19 EST by Paul Elder CLA
Modified: 2014-01-23 03:00 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Elder CLA 2014-01-17 14:19:33 EST 
+++ This bug was initially created as a clone of Bug #412001 +++
Cloning for fix on 4.3.2

Broken in 4.2.2 and in 4.3; works fine 3.8.2.

Probably a similar reason as bug 411602.

- open a text editor
- open a dialog with a "?" (Help) button (e.g. About Eclipse) and click the "?"
- click a link to get to an HTML page
- click into the Browser widget
- press Ctrl+F
=> the keystroke is wrongly processed by the workbench window. Find/Replace dialog is opened in the workbench window (behind the dialog). Can also be reproduced in a persisted Javadoc hover (F2).
Comment 1 Paul Elder CLA 2014-01-17 14:43:14 EST 
Patch for R43_maintenance pushed to Gerrit for review:

https://git.eclipse.org/r/20768

Reviewer should be sure to verify the steps described on https://bugs.eclipse.org/bugs/show_bug.cgi?id=420742#c4, as well as the description on this defect.
Comment 3 Paul Elder CLA 2014-01-17 16:41:39 EST 
(In reply to Paul Elder from comment #2)
> Release on R4_3_maintenance as:
> 
> https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?h=R4_3_maintenance&id=c1c38582be71611017f6cd654af1879a2c851043

Resolving.
Comment 4 Dani Megert CLA 2014-01-23 03:00:44 EST 
Verified in M20140122-1000.
Also verified that it doesn't break the Key Assist dialog on Linux, see bug 420742.