Community
Participate
Working Groups
Summary: the 'excludes' pattern in org.eclipse.ui.navigator.viewer.viewerActionBinding/viewerContentBinding is basically useless. The documentation states that 'excludes' have precedence over 'includes' as one would expect both intuitively. It's just that it does not work, and it turns out this is just because the code says otherwise. Proposed fix: in class org.eclipse.ui.internal.navigator.extensions.Binding method boolean isVisibleExtension(String anExtensionId) => move the loop over excludePatterns *before* the loop over includePatterns. This bug report relates to https://bugs.eclipse.org/bugs/show_bug.cgi?id=232860 entitled "[CommonNavigator] excludePatterns field in navigator extensions Binding class is pointless.", but it was never fixed. Severity 'major' even if this is a trivial fix, because instead of including org.eclipse.ui.navigator.resources.actions.* and just filtering out a couple of actions that I would like to provide myself, I have to write the inclusion in extension: org.eclipse.ui.navigator.resources.actions.EditActions org.eclipse.ui.navigator.resources.actions.RefactorActions org.eclipse.ui.internal.navigator.resources.actions.OpenActionProvider org.eclipse.ui.navigator.resources.GotoActions org.eclipse.ui.navigator.resources.GoIntoActions org.eclipse.ui.navigator.resources.PropertiesActionProvider org.eclipse.ui.navigator.resources.WorkManagementActionProvider org.eclipse.ui.navigator.resources.ResourceMgmtActions org.eclipse.ui.navigator.resources.UndoRedoActionProvider org.eclipse.ui.navigator.resources.WorkingSetActions
There's no one looking at this component at the moment, but we accept contributions. See http://wiki.eclipse.org/Platform_UI/How_to_Contribute PW
Ok. So be it, it's my first time contributing to Eclipse! Discovered and used Gerrit for the first time, signed the Contributor License Agreement, and pushed the change. You can see it at https://git.eclipse.org/r/#/c/20702/ What happens now?
Thanks for the contribution. We have community contribution days, the next one in about 2 weeks. I'll look at the contribution then. PW
Matthieu, can you provide a test case or small test bundle that allows to verify your fix?
Created attachment 239194 [details] Simple test case of includes/excludes pattern Attached a sample bundle that adds a viewerActionBinding including all actions from org.eclipse.ui.navigator.resources.* but excluding org.eclipse.ui.navigator.resources.NewActions The expected behavior is that the "New" menu does not show when right-clicking in the ProjectExplorer.
(In reply to Matthieu Wipliez from comment #5) > Created attachment 239194 [details] > Simple test case of includes/excludes pattern Thanks Matthieu. We'll be examining contributions at the beginning of next week. As Dani mentioned, could you please update your credentials in the copyright header at the top of the file in https://git.eclipse.org/r/#/c/20702/ ? Thanks, PW
Hi Paul, I did, but I've been unable to push my changes: they have been rejected telling me I should "sign off" on the contribution (even though there were proper change-id and signed-off-by fields). How should I proceed? Matthieu (In reply to Paul Webster from comment #6) > (In reply to Matthieu Wipliez from comment #5) > > Created attachment 239194 [details] > > Simple test case of includes/excludes pattern > > Thanks Matthieu. We'll be examining contributions at the beginning of next > week. As Dani mentioned, could you please update your credentials in the > copyright header at the top of the file in > https://git.eclipse.org/r/#/c/20702/ ? > > Thanks, > PW
If you use git format-patch (or any kind of diff on that commit) and attach the patch I can upload it for you. Can you check with a git log? Sometimes if you have a merge node + your commit change it gets rejected (we do fast-forward only commits in platform ui, so you might need to rebase on origin/master) Thanks, PW
Created attachment 239332 [details] Contributor patch
I tried to rebase and push but I have the same results, so I'm going with the patch approach, please find it attached. Matthieu (In reply to Paul Webster from comment #8) > If you use git format-patch (or any kind of diff on that commit) and attach > the patch I can upload it for you. > > Can you check with a git log? Sometimes if you have a merge node + your > commit change it gets rejected (we do fast-forward only commits in platform > ui, so you might need to rebase on origin/master) > > Thanks, > PW
Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f6fadfe1c6ba9806e246ccf4efbd989bae866b78 Thanks Matthieu PW
In 4.4.0.I20140303-2000 Matthieu, could you also confirm it now works the way you expect? PW
*** Bug 232860 has been marked as a duplicate of this bug. ***
Yes I confirm it works as expected with integration build 4.4.0.I20140303-2000 Matthieu (In reply to Paul Webster from comment #12) > In 4.4.0.I20140303-2000 > > Matthieu, could you also confirm it now works the way you expect? > > PW
