Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 424525 - ScoutAction renderer hierarchy in Swt
Summary: ScoutAction renderer hierarchy in Swt
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Scout (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 422646
  Show dependency tree
 
Reported: 2013-12-20 08:03 EST by Jeremie Bresson CLA
Modified: 2021-08-19 11:22 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremie Bresson CLA 2013-12-20 08:03:29 EST 
If you have a look at the AbstractAction (scout model) hierarchy:
---AbstractAction
   +---AbstractToolButton
   |   \---AbstractMenu
   +---AbstractKeyStroke
   +---AbstractToolButton
   |   \---AbstractFromToolButton<FORM>
   \---AbstractViewButton
       \---AbstractOutlineViewButton

This hierarchy isn’t reflected in the Swt renderer plugin, leading to incomplete behavior.
For example the AbstractSwtAction (corresponding to the Scout AbstractAction), does’nt react on AbstractAction#setEnabled().

The hierarchy in the SWT Part should be fixed.
Comment 1 Jeremie Bresson CLA 2013-12-27 06:22:37 EST 
Minimal change (common code between SwtScoutAction and AbstractSwtMenuAction):
https://git.eclipse.org/r/20169

The problem is that there is still some duplicate code between SwtScoutComposite and AbstractSwtScoutAction. I will try to come with a v2 of the change.
Comment 2 Jeremie Bresson CLA 2013-12-27 09:22:54 EST 
The second version is pushed to Gerrit:
https://git.eclipse.org/r/#/c/20169/2 

Common code between AbstractSwtScoutAction and SwtScoutComposite is now in SwtScoutListener.
Comment 3 Jeremie Bresson CLA 2014-01-22 11:58:06 EST 
Pushed with commit b870ee6c71fb7647ae3663b236c7b9fd9d1a0ccc on develop:

http://git.eclipse.org/c/scout/org.eclipse.scout.rt.git/commit/?id=b870ee6c71fb7647ae3663b236c7b9fd9d1a0ccc

@Matthias.Nick:
Can you verify please?
Comment 4 Matthias Nick CLA 2014-02-10 03:31:56 EST 
Change looks good to me. Verified with org.eclipse.scout.rt.ui.swt	3.10.0.20140205-1810
Comment 5 Matthias Zimmermann CLA 2014-07-01 03:19:02 EDT 
Shipped with Eclipse Luna Release