This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 424204 - [eslint] Report missing doc tags
Summary: [eslint] Report missing doc tags
Status: CLOSED DUPLICATE of bug 420083
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 00:54 EST by Michael Rennie CLA
Modified: 2015-05-08 10:19 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2013-12-17 00:54:14 EST
We should create an eslint rule that will check for missing doc tags in the following cases:

1. there is a parameter that is not doc'c with an @param tag
2. the function has a return statement but is missing an @returns tag
3. the function throws an exception (throw statement in the function) but does not have an @throws tag
4. missing @description tag

optional tag checks could be:

1. missing @memberof
2. missing visibility - @public / @private
3. missing @name


Ideally these checks would directly follow whatever we decide is the 'Orion way' to doc things.
Comment 1 Michael Rennie CLA 2013-12-20 14:58:11 EST
(In reply to Michael Rennie from comment #0)
> We should create an eslint rule that will check for missing doc tags in the
> following cases:
> 
> 1. there is a parameter that is not doc'c with an @param tag
> 2. the function has a return statement but is missing an @returns tag
> 3. the function throws an exception (throw statement in the function) but
> does not have an @throws tag
> 4. missing @description tag
> 
> optional tag checks could be:
> 
> 1. missing @memberof
> 2. missing visibility - @public / @private
> 3. missing @name
> 
> 
> Ideally these checks would directly follow whatever we decide is the 'Orion
> way' to doc things.

Along with checking the tags we will have to check that the comment (if one exists) is a block comment since missing tag checking implies you are using JSDoc-style comments.
Comment 2 John Arthorne CLA 2015-05-05 16:20:47 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html
Comment 3 Curtis Windatt CLA 2015-05-05 16:35:08 EDT
Reopening
Comment 4 Michael Rennie CLA 2015-05-08 10:19:22 EDT
The valid-jsdoc rule would cover this as well (bug 420083).

Marking as a dupe.

*** This bug has been marked as a duplicate of bug 420083 ***