Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 424129 - [Workbench] 3.6.2 RCP application does not run correctly on 4.3 (workbench window is launching)
Summary: [Workbench] 3.6.2 RCP application does not run correctly on 4.3 (workbench wi...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 4.3.2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 413096
Blocks:
  Show dependency tree
 
Reported: 2013-12-16 09:42 EST by Paul Webster CLA
Modified: 2014-01-30 13:35 EST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2013-12-16 09:42:42 EST 
Patch back simple openWindows() fix to 4.3.2


+++ This bug was initially created as a clone of Bug #413096 +++

I have an 3.6.2 RCP application that is basically a jface wizard. I need a workbench only so I can use the help system. I only want the jface wizard launched I don't want the workbench launched. To get this to only show the wizard on 3.6.2 I implemented the postStartup() method my ApplicationWorkbenchAdvisor class.  It basically did the creation of the wizard and launched it. 

I needed to setBlockOnOpen to false so that I could use progress monitors (indeterminate) in the application. 

Now I moved to a 4.3 eclipse base and tried to run this 3.6.2 application from that. It no longer works. The behavior in 4.3 is that is shows the workbench window as well as my jface wizard. I am stumped as to how to fix this.

I have attached a small sample application that shows this issue.

Note: If I set setBlockOnOpen(true) then I don't see the workbench window but then my progress monitors (indeterminate) no longer work. So that is not an option.

I need help asap as I have a schedule to make in a couple of weeks.
Comment 1 Paul Webster CLA 2013-12-16 09:44:18 EST 
Change for 4.3.2
https://git.eclipse.org/r/19858

PW
Comment 2 Paul Webster CLA 2013-12-19 09:58:53 EST 
(In reply to Paul Webster from comment #1)
> Change for 4.3.2
> https://git.eclipse.org/r/19858

Paul, could I get you to review this?

PW
Comment 3 Paul Elder CLA 2013-12-19 15:09:45 EST 
(In reply to Paul Webster from comment #2)
> (In reply to Paul Webster from comment #1)
> > Change for 4.3.2
> > https://git.eclipse.org/r/19858
> 
> Paul, could I get you to review this?
> 
> PW

Looks good, released on R4_3_maintenance as:

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_3_maintenance&id=7ac22c8db178606b0815b4df5aced9e12dcf8db0
Comment 4 Paul Elder CLA 2014-01-30 13:35:38 EST 
Verified in 4.3.2.M20140129-0800