This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 423893 - [EditorMgmt][Split editor] Key bindings don't work (Mac)
Summary: [EditorMgmt][Split editor] Key bindings don't work (Mac)
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.4 M5   Edit
Assignee: Paul Webster CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-12 06:06 EST by Markus Keller CLA
Modified: 2014-01-24 11:00 EST (History)
1 user (show)

See Also:

Attachments
Fix (1.94 KB, patch)
2014-01-21 14:06 EST, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-12-12 06:06:15 EST 
I20131210-2000

On the Mac, the key bindings Command+_ and Command+{ don't work with a U.S. keyboard layout.
Comment 1 Markus Keller CLA 2014-01-21 14:06:58 EST 
Created attachment 239201 [details]
Fix

The patch fixes the problem by defining custom key bindings for the Mac (with the same keys as the original bindings tried to use).


The problem is that the KeyDown event for Command+Shift+- has field values:

  character='-'=0x2d keyCode=0x2d stateMask=0x420000

on the Mac. Shift+- produces character='_'=0x5f, but the '_' character is lost when Command is added.

This seems to be the normal system behavior on the Mac. The Keyboard Viewer confirms that the Shift key has no effect on the character any more as soon as Command is pressed.

The same explanation also holds for Command+Shift+[:
  character='['=0x5b keyCode=0x5b stateMask=0x420000
, again losing the character for Shift+[, which would be character='{'=0x7b.

I don't think we should try to fight the platform behavior here.
Comment 2 Paul Webster CLA 2014-01-22 15:05:00 EST 
Released with a minor mod as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=77e57f52ebe0b317dd8bd03705ddfb2f684ae6aa

Thanks Markus.

PW
Comment 3 Paul Webster CLA 2014-01-24 11:00:58 EST 
on 4.4.0.I20140123-1600 on a mac

PW