This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 423892 - [EditorMgmt][Split editor] Only one command available in Quick Access
Summary: [EditorMgmt][Split editor] Only one command available in Quick Access
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.4 M5   Edit
Assignee: Paul Webster CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-12 06:01 EST by Markus Keller CLA
Modified: 2014-01-21 10:28 EST (History)
2 users (show)

See Also:

Attachments
Screenshot (15.89 KB, image/png)
2014-01-21 04:33 EST, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-12-12 06:01:43 EST 
I20131210-2000

In Quick Access (Command+3), I only see one Split Editor command, which splits vertically (creates a horizontal separator).
Comment 1 Paul Webster CLA 2013-12-12 10:58:21 EST 
Fix for the command names with parameters for Quick Access and Keys preference page:

https://git.eclipse.org/r/19716

PW
Comment 3 Dani Megert CLA 2014-01-08 12:02:31 EST 
Now I see 3 (see bug 423890 comment 4).
Comment 4 Lars Vogel CLA 2014-01-21 04:33:41 EST 
I think the description in the Quickaccess is a bit weird. "It can be split either horizontally or vertically." shows up for the "Split horizontal" and "Split vertical" command. 

I suggest to remove the "It can be split either horizontally or vertically." string as it is misleading for the individual commands.

https://git.eclipse.org/r/20859
Comment 5 Lars Vogel CLA 2014-01-21 04:33:54 EST 
Created attachment 239165 [details]
Screenshot
Comment 6 Paul Webster CLA 2014-01-21 05:43:29 EST 
That leaves the description "Split or join the currently active editor."  Is that sufficient?

PW
Comment 7 Lars Vogel CLA 2014-01-21 05:57:19 EST 
(In reply to Paul Webster from comment #6)
> That leaves the description "Split or join the currently active editor."  Is
> that sufficient?
> 
> PW

In the Quick access menu you get:

Toogle Split Editor (Horizontal) - Split or join the currently active editor
Toogle Split Editor (Vertical) - Split or join the currently active editor

which is sufficient IMHO.

Where else is the description visible? In the Keybindings I only see Toogle Split Editor (Horizontal) or Toogle Split Editor (Vertical)
Comment 8 Dani Megert CLA 2014-01-21 06:04:27 EST 
(In reply to Lars Vogel from comment #7)
> (In reply to Paul Webster from comment #6)
> > That leaves the description "Split or join the currently active editor."  Is
> > that sufficient?
> > 
> > PW
> 
> In the Quick access menu you get:
> 
> Toogle Split Editor (Horizontal) - Split or join the currently active editor
> Toogle Split Editor (Vertical) - Split or join the currently active editor
> 
> which is sufficient IMHO.

I agree. Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=eee1f3d38e2dafe92a28612918e71dbd82897ca4
Comment 9 Eric Moffatt CLA 2014-01-21 10:28:16 EST 
Verified in 4.4.0.I20140120-2000