This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 423890 - [EditorMgmt][Split editor] Commands have bad names
Summary: [EditorMgmt][Split editor] Commands have bad names
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.4 M5   Edit
Assignee: Paul Webster CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-12 05:55 EST by Markus Keller CLA
Modified: 2014-01-16 05:45 EST (History)
1 user (show)

See Also:


Attachments
Screenshot (28.08 KB, image/png)
2013-12-12 05:55 EST, Markus Keller CLA
no flags Details
Picture with the 3 commands (in Ctrl+3) (15.77 KB, image/png)
2014-01-08 12:03 EST, Dani Megert CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-12-12 05:55:03 EST
Created attachment 238277 [details]
Screenshot

I20131210-2000

The Split Editor commands have bad names. I would expect one command to split horizontally and one to split vertically.
Comment 1 Markus Keller CLA 2013-12-12 05:59:06 EST
And the descriptions should also tell what each command does.
Comment 2 Paul Webster CLA 2013-12-12 10:56:45 EST
I'll fix this with bug 423892

PW
Comment 4 Dani Megert CLA 2014-01-08 11:57:19 EST
This is not solved: I still see 3 (instead of 2) commands and all have the same description:

"Split or join the currently active editor.  It can be split either horizontally or vertically."
Comment 5 Dani Megert CLA 2014-01-08 12:03:17 EST
Created attachment 238785 [details]
Picture with the 3 commands (in Ctrl+3)
Comment 6 Paul Webster CLA 2014-01-08 13:44:56 EST
(In reply to Dani Megert from comment #4)
> This is not solved: I still see 3 (instead of 2) commands and all have the
> same description:
> 
> "Split or join the currently active editor.  It can be split either
> horizontally or vertically."

Yes, this is the same way that Show View or Show In or Preferences works.  It will show you the parameterized commands with the representation of their parameter in '()' and because there are so few, it also shows the default command with no parameterization.

I'll try making the parameter non-optional, so you have to choose one or the other.

Another thing we can do is enhance the description so it states the default behaviour if no parameter is given.

PW
Comment 7 Dani Megert CLA 2014-01-09 04:39:08 EST
(In reply to Paul Webster from comment #6)
> Another thing we can do is enhance the description so it states the default
> behaviour if no parameter is given.

That would work for me.
Comment 8 Dani Megert CLA 2014-01-09 04:57:18 EST
(In reply to Dani Megert from comment #7)
> (In reply to Paul Webster from comment #6)
> > Another thing we can do is enhance the description so it states the default
> > behaviour if no parameter is given.
> 
> That would work for me.

Actually, that might be harder than removing the non-parametrized command. If I look at "Show In (*)", I see that they share the same description and the non-parametrized "Show In" does not appear on the Keys preference page or with Ctrl+3.
Comment 9 Paul Webster CLA 2014-01-14 13:46:53 EST
Remove the non-parameterized version of the command: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c8bef62e8223fe0d50e455ba7555babc4cebe413 and http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5c234b1e41ed727415f695eb3b71439751d1c16a

Now only the 2 commands show up in quick access and the keys pref page.

PW
Comment 10 Dani Megert CLA 2014-01-15 06:49:33 EST
Argh! It "works" but we now get this each time a workspace (even new one) is started:

!MESSAGE Conflicting handlers for org.eclipse.ui.window.splitEditor: {org.eclipse.ui.internal.SplitHandler@a691d3} vs {org.eclipse.ui.internal.SplitHandler}
Comment 11 Paul Webster CLA 2014-01-15 10:31:29 EST
OK, that was an extra default handler.  Removed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1f2e7c9d79cc5f66076df1daa952acd0bf96e161

PW
Comment 12 Dani Megert CLA 2014-01-16 05:45:41 EST
Verified in N20140115-2000.