Community
Participate
Working Groups
My wizard are attached to a category which is itself attached to a root category but which has no wizard. The hierarchy is: RootCat --> ChildCat --> Wizard1, Wizard2 The org.eclipse.ui.internal.dialog.WizardPatternFilter now (since LunaM3) now filters out categories that have no direct wizard so as a consequence, my wizards are now shown anymore. It notice the same for the Examples category. I think this is since LunaM3 but I'm note 100% sure. I'm sure my wizards are ok on Kepler, Juno, Indigo, Helios and Galileo (thank you Tycho and UT)
Possibly more fallout from Bug 408763 like Bug 419710 PW
Will try with Luna staging and let you know
(In reply to Jeff MAURY from comment #2) > Will try with Luna staging and let you know Could you please attach the sample plugin that exposes the issue? The filtering of wizards is very sensitive area of the code and the probability of the regression is very high. We have to make sure that the new fix will handle all cases. thanks, Daniel
Created attachment 238294 [details] Sample plugin A sample plugin that shows the issue
I've pushed the patch proposal to Gerrit that seems to be working fine for all cases: https://git.eclipse.org/r/#/c/20428/ thanks, Daniel
(In reply to Daniel Rolka from comment #5) > I've pushed the patch proposal to Gerrit that seems to be working fine for > all cases: https://git.eclipse.org/r/#/c/20428/ With all cases, you mean all cases described here, bug 408763 and bug 419710? Would be good to have test cases for those, to avoid future breakages.
(In reply to Dani Megert from comment #6) > (In reply to Daniel Rolka from comment #5) > > I've pushed the patch proposal to Gerrit that seems to be working fine for > > all cases: https://git.eclipse.org/r/#/c/20428/ > > With all cases, you mean all cases described here, bug 408763 and bug > 419710? Would be good to have test cases for those, to avoid future > breakages. By all cases I mean the following bugs: Bug 408763, Bug 419710 and the current use case Daniel
Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fb703ae64d2be04529fed1eb8875ac2ef68eb932 Would still be good to have test cases.
Please not I have submitted a sample that demonstrated the issue
(In reply to Jeff MAURY from comment #9) > Please not I have submitted a sample that demonstrated the issue Do you have any new use case where the new fix doesn't work? Daniel
I did not test the fix. Do I need to build Eclipse myself or it there a build/P2 repo available ?
(In reply to Jeff MAURY from comment #11) > I did not test the fix. Do I need to build Eclipse myself or it there a > build/P2 repo available ? The fix should be available in the following builds: http://download.eclipse.org/eclipse/downloads/drops4/I20140115-1300/ http://download.eclipse.org/eclipse/downloads/drops4/N20140115-2000/ Daniel
I will test it and let you know
(In reply to Dani Megert from comment #8) > Submitted with > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=fb703ae64d2be04529fed1eb8875ac2ef68eb932 > > Would still be good to have test cases. OK, so let's leave the bug opened and I'll prepare the proper test suite for it Daniel
It's better for bookkeeping if we mark this FIXED for M5. Filed bug 426560 for adding the tests.
Verified in the build: I20140120-2000 Daniel
