423725 – [Contributions] Popup menus slowdown over time (> 5 seconds)

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 423725 - [Contributions] Popup menus slowdown over time (> 5 seconds)

Summary: [Contributions] Popup menus slowdown over time (> 5 seconds)

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.3.1
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	4.3.2
Assignee:	Paul Webster
QA Contact:	Daniel Rolka

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-12-10 11:41 EST by Michael Valenta
Modified:	2014-01-30 15:14 EST (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Valenta

2013-12-10 11:41:41 EST

I've debugged this with Paul and it appears the issue is in 

org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.merge(MExpression, MExpression)

because the two expressions are identical. This causes the expression to grow larger and larger on every menu popup which makes the menu take longer to show up.

Comment 1 Paul Webster

2013-12-13 10:58:53 EST

https://git.eclipse.org/r/19796

Fix for master.  We can review it and then cherry-pick for R4_3_maintenance

PW

Comment 2 Dani Megert

2013-12-17 06:48:01 EST

Which context menu triggers the code? I've set a breakpoint in ContributionRecord.merge(MExpression, MExpression) but it was never reached.

Maybe the problem is already fixed with the change made for bug 398381, which also reported a leak?

Comment 3 Paul Webster

2013-12-17 09:46:25 EST

(In reply to Dani Megert from comment #2)
> Which context menu triggers the code? I've set a breakpoint in
> ContributionRecord.merge(MExpression, MExpression) but it was never reached.

In RTC, it was the org.eclipse.ui.projectConfigure menu.  It was triggered reliably in Kepler.

I can't reproduce this in Luna SDK by default.  But if I provide 2 org.eclipse.ui.menus extensions that share a menu I can reproduce the problem if their core expressions are different.

Maybe we're not hitting it with the default Configure submenu any more because that leak was fixed.

PW

Comment 4 Paul Elder

2013-12-20 09:09:20 EST

Released on master as:

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b13507a4b9706e1e4aecc5a51160c7d3c84385e7

Comment 5 Paul Webster

2013-12-20 10:36:43 EST

I've pushed a review for 4.3.2 https://git.eclipse.org/r/20122

PW

Comment 6 Dani Megert

2014-01-10 07:24:21 EST

(In reply to Paul Webster from comment #5)
> I've pushed a review for 4.3.2 https://git.eclipse.org/r/20122
> 
> PW

Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e7addbf24f20d0f9bfdbb7f1774c6900c53cf150

Updated copyright date with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d13f24c187ac10dfb94a09d1b7b8fb2389c605b0

Comment 7 Paul Webster

2014-01-30 15:14:21 EST

In 4.3.2.M20140129-0800

PW