This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 423718 - Regression: closing the Welcome view leaves the WBW in a strange state
Summary: Regression: closing the Welcome view leaves the WBW in a strange state
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M4   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-10 10:55 EST by Eric Moffatt CLA
Modified: 2013-12-12 09:20 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-12-10 10:55:38 EST 
Found while checking 4.4.0.I20131209-2000.

I had a workspace with a maximized editor...
installed EGit and restarted
closed the resulting Welcome screen

I ended up with all the stacks restored to the presentation but the shared area was still 'maximized'. Closing the Welcome shouldn't affect the state of the regular presentation at all...
Comment 1 Eric Moffatt CLA 2013-12-10 10:56:12 EST 
Marking for a look tomorrow as this is a regression of some kind...
Comment 2 Eric Moffatt CLA 2013-12-11 10:56:19 EST 
Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=75ffbc303c1e30c1a1741e193ffc33aedbd9eecd

This safes up the code so that if the element being un-zoomed is outside the perspective then only restore stacks that are also outside any perspective...
Comment 3 Eric Moffatt CLA 2013-12-12 09:20:41 EST 
Verified in 4.4.0.I20131211-2000.