Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 423704 - [CSS] Update the classic theme to use the default color and font definitions
Summary: [CSS] Update the classic theme to use the default color and font definitions
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M5   Edit
Assignee: Daniel Rolka CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 423768
Blocks: 424037
  Show dependency tree
 
Reported: 2013-12-10 08:42 EST by Daniel Rolka CLA
Modified: 2014-01-21 10:48 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Rolka CLA 2013-12-10 08:42:32 EST 
Since the Bug 419016 is ready we can update the CSS stylesheets with proper theme element definitions to connect the GUI with the ColorAndFontPreferencePage dialog. 
We have decided to update the 'classic' stylesheets first to get some feedback
Comment 1 Daniel Rolka CLA 2013-12-10 08:49:11 EST 
Initial version of the patch has been pushed to Gerrit: https://git.eclipse.org/r/#/c/19579/

Daniel
Comment 2 Daniel Rolka CLA 2013-12-10 08:59:46 EST 
(In reply to Daniel Rolka from comment #1)
> Initial version of the patch has been pushed to Gerrit:
> https://git.eclipse.org/r/#/c/19579/
> 
> Daniel

The review link has been updated: https://git.eclipse.org/r/#/c/18383/

Daniel
Comment 3 Daniel Rolka CLA 2013-12-13 13:38:48 EST 
The additional change required by the first patch: https://git.eclipse.org/r/#/c/19810/

Daniel
Comment 4 Daniel Rolka CLA 2013-12-17 05:11:35 EST 
The bug 423607 has stopped to block the current one since in the current version of the patch we use the 'swt-selected-tabs-background' property instead of regular 'background-color' one to style the MPart backgrounds

Daniel
Comment 5 Paul Elder CLA 2014-01-10 09:10:32 EST 
(In reply to Daniel Rolka from comment #3)
> The additional change required by the first patch:
> https://git.eclipse.org/r/#/c/19810/
> 
> Daniel

Released on master as:

https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=aa83bea8cf40e5aa399a8065bba001b25e95d2ff

Daniel, do you want me to review the CSS change itself?

https://git.eclipse.org/r/#/c/18383/
Comment 6 Daniel Rolka CLA 2014-01-10 09:23:03 EST 
(In reply to Paul Elder from comment #5)
> (In reply to Daniel Rolka from comment #3)
> > The additional change required by the first patch:
> > https://git.eclipse.org/r/#/c/19810/
> > 
> > Daniel
> 
> Released on master as:
> 
> https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=aa83bea8cf40e5aa399a8065bba001b25e95d2ff
> 
> Daniel, do you want me to review the CSS change itself?
> 
> https://git.eclipse.org/r/#/c/18383/

This change enables the CSS bridge (the user will be able to modify the MPart title fonts and MPart colors with the ColorsAndFontsPreferencePage preference page). So if it works fine for you and Paul W. wants to push it now, please commit it

thanks,
Daniel
Comment 7 Daniel Rolka CLA 2014-01-10 09:39:42 EST 
I forgot to add - it enables the bridge for the classic theme only. It is the transparent change for the classic GUI and it shouldn't introduce any regression in its layout. 

When it is such need, we can port it to the rest of the CSS themes.

Daniel
Comment 9 Daniel Rolka CLA 2014-01-21 10:48:47 EST 
Verified in the build: eclipse-SDK-I20140120-2000

Daniel