Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 423136 - [Perspectives] SHOW_OPEN_ON_PERSPECTIVE_BAR settings not taken into account
Summary: [Perspectives] SHOW_OPEN_ON_PERSPECTIVE_BAR settings not taken into account
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows XP
: P3 normal with 7 votes (vote)
Target Milestone: 4.6 M5   Edit
Assignee: Jonas Helming CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-04 02:47 EST by Cedric Moonen CLA
Modified: 2016-01-25 08:43 EST (History)
11 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric Moonen CLA 2013-12-04 02:47:11 EST 
These two options do not have any effect anymore on e4:

- SHOW_OPEN_ON_PERSPECTIVE_BAR: setting this preference to false do not hide the open perspective button (this was working before)
- PERSPECTIVE_BAR_EXTRAS: the extra perspectives listed here are not shown by default on the perspective bar.

Those settings were set in the ApplicationWorkbenchWindowAdvisor:

IPreferenceStore prefStore = PlatformUI.getPreferenceStore();
		prefStore.setValue(IWorkbenchPreferenceConstants.DOCK_PERSPECTIVE_BAR,
				"RIGHT");
		prefStore.setValue(
				IWorkbenchPreferenceConstants.SHOW_TRADITIONAL_STYLE_TABS,
				false);
		prefStore.setValue(
				IWorkbenchPreferenceConstants.SHOW_OTHER_IN_PERSPECTIVE_MENU,
				false);
		prefStore.setValue(
				IWorkbenchPreferenceConstants.SHOW_OPEN_ON_PERSPECTIVE_BAR,
				false);
		prefStore.setValue(
				IWorkbenchPreferenceConstants.PERSPECTIVE_BAR_EXTRAS,
				LogAnPerspective.PERSPECTIVE_ID + ","
						+ PatternEditPerspective.PERSPECTIVE_ID + ","
						+ DebugPerspective.PERSPECTIVE_ID);
Comment 1 Olivier Labrosse CLA 2014-06-30 12:06:40 EDT 
This is an issue for us as well, as we have a closed set of perspectives and we want them all to be displayed in the bar.
Comment 2 Sébastien Gandon CLA 2014-11-07 09:18:00 EST 
es we at Talend have the same issue.
Comment 3 Marcus CLA 2015-01-12 12:45:36 EST 
Same here.  Our application has a fixed set of perspectives we want to be initially shown for users on the perspective bar.
Comment 4 Stefan Prieschl CLA 2015-09-07 07:14:27 EDT 
We have the same problem, where PERSPECTIVE_BAR_EXTRAS has no effect.
The problem also exists for a system with Windows 7, Eclipse 4.5, Java 8.

The flag worked for Eclipse 3.7, but doesn't work for Eclipse e4 anymore.
Is there an alternative in eclipse e4 to get the same behaviour with something else? We want to show all perspectives at startup.
Comment 5 Eclipse Genie CLA 2015-09-17 15:26:27 EDT 
New Gerrit change created: https://git.eclipse.org/r/56196
Comment 6 Jonas Helming CLA 2015-09-17 15:30:22 EDT 
The patchs adds support for the SHOW_OPEN_ON_PERSPECTIVE_BAR.

For the extra perspectives I would rather not extend the PerspectiveSwitcher, because I would deal with it separately. The current idea of the perspective bar is that the toolbar shows all perspectives, which are on the perspective stack already. If you want more perspectives in there, I would rather place them on the perspective stack from the beginning...
Comment 7 Stefan Prieschl CLA 2015-09-29 14:18:44 EDT 
Thank you for this patch.

But there is still a bug, that the flag PERSPECTIVE_BAR_EXTRAS doesn't work.
We want to upgrade old eclipse applications to eclipse e4. I think that there are lots of people that want to do that. Therefore it would be nice, if the compatibility layer would work exactly like the old eclipse version, to avoid sourcecode changes.
Comment 8 Jonas Helming CLA 2015-10-06 05:45:39 EDT 
I am creating another bug for the remaining topic to be able to close this one first, see Bug 479126
Comment 10 Jonas Helming CLA 2016-01-22 05:44:54 EST 
Please verify it the next build