422802 – Remove unnecessary else statements from org.eclipse.e4.ui.workbench.swt

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 422802 - Remove unnecessary else statements from org.eclipse.e4.ui.workbench.swt

Summary: Remove unnecessary else statements from org.eclipse.e4.ui.workbench.swt

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.4
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.4 M7
Assignee:	Lars Vogel
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	420779
	Show dependency tree

Reported:	2013-11-28 14:59 EST by Lars Vogel
Modified:	2014-04-07 04:59 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2013-11-28 14:59:13 EST

Looks like org.eclipse.e4.ui.workbench.swt contains several unnecessary casts and is missing overrides and has some unnecesssary NLS entries.

I suggest to clean this plug-in up and activate the save actions on it.

Comment 1 Lars Vogel

2013-11-28 15:01:52 EST

Also with the new @Override annotations, I think the 
/*
	 * (non-Javadoc)
	 * 
	 * @see

stuff can be removed.

Comment 2 Lars Vogel

2013-11-28 15:11:01 EST

Also several // TODO Auto-generated catch block comments

Comment 3 Lars Vogel

2013-11-28 15:16:20 EST

First round of cleanups

https://git.eclipse.org/r/19088

Comment 4 Lars Vogel

2014-03-12 06:14:24 EDT

Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d6a7d253b87968e5f0ef552c894a7cab0b9eec63

Comment 5 Lars Vogel

2014-04-07 04:59:44 EDT

Verified in Git