422499 – Filtering for outliner does not find non-visible items

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 422499 - Filtering for outliner does not find non-visible items

Summary: Filtering for outliner does not find non-visible items

Status:	RESOLVED FIXED

Alias:	None

Product:	Orion
Classification:	ECD
Component:	Client (show other bugs)
Version:	5.0
Hardware:	PC Mac OS X

Importance:	P3 normal (vote)
Target Milestone:	5.0 M2
Assignee:	Elijah El-Haddad
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	374400
	Show dependency tree

Reported:	2013-11-25 13:07 EST by Michael Rennie
Modified:	2014-02-21 15:52 EST (History)
CC List:	3 users (show)

See Also:

Flags:	Silenio_Quarti: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Rennie

2013-11-25 13:07:55 EST

The new filtering support for outliners does not find an item if it is not showing in the view when the filtering is done. I would assume anything in the outliner model (the returned outline) could be found, visible or not.

Comment 1 Elijah El-Haddad

2013-12-06 13:23:20 EST

Part 1 of fix:
https://github.com/elijahe/orion.client/commit/063a031fa67b3892e6df900970e02ee82d695467

Part 2 of fix:
https://github.com/elijahe/orion.client/commit/83b5863f37fe29dc06a449964df820dc5a28f7b2

Comment 2 Elijah El-Haddad

2013-12-06 16:06:26 EST

Additional commit after Silenio's review: https://github.com/elijahe/orion.client/commit/1b31a8765854d4939079a8ba2b415b63182410ed

Comment 3 Silenio Quarti

2013-12-06 16:23:30 EST

Pushed the 3 commits to eclipse.org.

Comment 4 Elijah El-Haddad

2013-12-30 11:50:44 EST

- Prevent focus from falling off the first or last selectable item while items are being traversed using the keyboard
https://github.com/elijahe/orion.client/commit/436e275f6c239bd9ab88ee702371552e71025293

Comment 5 libing wang

2013-12-30 12:04:40 EST

Pushed the last commit with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ec2330254246ce4c866621094ee6aecd4c3fc641

Comment 6 Elijah El-Haddad

2014-01-02 12:18:20 EST

This bug is fixed.