This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 422350 - [Perspectives] Placeholder with secondary ID is being relocated to false container causing views to show at false location
Summary: [Perspectives] Placeholder with secondary ID is being relocated to false cont...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.3.2   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 409834
Blocks:
  Show dependency tree
 
Reported: 2013-11-22 10:57 EST by Eric Moffatt CLA
Modified: 2013-11-29 10:26 EST (History)
3 users (show)

See Also:
pwebster: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-11-22 10:57:31 EST 
+++ This bug was initially created as a clone of Bug #409834 +++

Suppose you create two placeholders in two different perspectives
a) MyView:* (PerpectiveA)
b) MyView:specialSecondaryId (PerspectiveB)

then PartServiceImpl#addPart(MPart providedPart, MPart localPart) for 
MyView:specialSecondaryId
tries to find the placeholder MyView:* and locates its container.

From the provided part the placeholder is determined which has id
MyView:specialSecondaryId and resides in perspectiveB.

The method however does not care about this placeholder and relocates it to the container of placeholder MyView:*.

The MyView:specialSecondaryId placeholder is thus being moved where it should not.

I suppose a search for the exact placeholder must occur before any wildcard placeholder is being searched.

Reading http://help.eclipse.org/indigo/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fui%2FIPageLayout.html
indicates that placeholders with secondaryIds are valid.
Comment 1 Eric Moffatt CLA 2013-11-22 10:58:24 EST 
This is th3 4.3.2 version of the defect...we should cherry pick the change from the 4.4 defect...
Comment 2 Eric Moffatt CLA 2013-11-22 11:05:32 EST 
Paul, would you review / cherry pick this across ?
Comment 4 Eric Moffatt CLA 2013-11-29 10:26:23 EST 
Verified in 4.3.0.M20131127-1300.