Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 422080 - Improve JavaScript outline (was: Improve the JSDoc outline)
Summary: Improve JavaScript outline (was: Improve the JSDoc outline)
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: JS Tools (show other bugs)
Version: 5.0   Edit
Hardware: PC Mac OS X
: P3 enhancement (vote)
Target Milestone: 5.0 M1   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 372249 (view as bug list)
Depends on: 422492 422495
Blocks:
  Show dependency tree
 
Reported: 2013-11-19 12:15 EST by Michael Rennie CLA
Modified: 2013-11-25 12:52 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2013-11-19 12:15:16 EST 
The first cut of outlining JSDoc is not sufficient. We should instead use the doc tag information to compose signatures and if possible place nodes in the correct hierarchy.
Comment 1 Michael Rennie CLA 2013-11-19 14:25:53 EST 
(In reply to Michael Rennie from comment #0)
> The first cut of outlining JSDoc is not sufficient. We should instead use
> the doc tag information to compose signatures and if possible place nodes in
> the correct hierarchy.

We should also show some kind of progress (or something) when the view is loading - for very large js files it appears blank while it is computing the outline (not good)
Comment 2 Michael Rennie CLA 2013-11-22 13:05:26 EST 
*** Bug 372249 has been marked as a duplicate of this bug. ***
Comment 3 Michael Rennie CLA 2013-11-22 13:57:59 EST 
I completely re-wrote the outliner using estraverse. It now looks just like a real source outline. The jsdoc hinting is not hooked up yet as we are still not using latest version of Esprima (which has the doc node linking).

https://git.eclipse.org/r/18753
Comment 4 Michael Rennie CLA 2013-11-25 11:25:04 EST 
The first cut of the re-write was merged with: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e81382db17a7360c3cdd2b5358aa8b5bbeb44d58

I'll mark this as fixed and open new issues / enhancements in their own bugs