Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 421481 - Remove "guest user" feature
Summary: Remove "guest user" feature
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 5.0 M1   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 405740 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-11-11 14:14 EST by Mark Macdonald CLA
Modified: 2013-11-19 11:03 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2013-11-11 14:14:15 EST 
In Orion 3.0 an optional "guest user" feature was added, which allowed logging in as a temporary user. These would persist until a limit was reached and then older ones would be purged.

However this added complexity to the auth and user code, and we did not end up enabling it on Orionhub or elsewhere. It should just be deleted.
Comment 1 Mark Macdonald CLA 2013-11-11 14:14:41 EST 
*** Bug 405740 has been marked as a duplicate of this bug. ***
Comment 3 Anthony Hunter CLA 2013-11-12 14:30:12 EST 
We removed all the bindings for UserServiceHelper from org.eclipse.orion.server.useradmin and not just the guest binding.

Added back in, could not create a new user otherwise, see commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=dba68d6eb901c0cc3a2736588a9c732b62fd7161
Comment 4 Mark Macdonald CLA 2013-11-12 14:36:47 EST 
Ugh, thanks for catching that.
Comment 5 John Arthorne CLA 2013-11-19 11:03:23 EST 
Compile errors are starting to show up in the Java source that was left behind, so I have deleted the entire guest bundle from master:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=b8d3ea698bdd834ccf7336eebfec2dd422530839

I left behind a readme as a reminder of where it was, and as a pointer for those who have clones and are wondering what happened to it.