Community
Participate
Working Groups
The E4 model currently has do representation for dialogs and wizards. Add MDialog and MWizard types (extending MWindow) to enable their representation.
Initial round of changes pushed to Gerrit for review: https://git.eclipse.org/r/18343 We will get these committed and into next week's I build so that people can start experimenting with implementations.
Pushed to master as: https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2b33bfa2e241ec0647a2d3bbd2e1c0070f970a1b Please provide comments on your progress and problems with implementing renderers for MDialog/MWizard.
(In reply to Paul Elder from comment #2) > Pushed to master as: > > https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=2b33bfa2e241ec0647a2d3bbd2e1c0070f970a1b There are 4 errors in API tools: Description Resource Path Location Type The major version should be incremented in version 1.1.0, since API breakage occurred since version 1.0.0 MANIFEST.MF /org.eclipse.e4.ui.model.workbench/META-INF line 5 Version Numbering Problem Missing @since tag on createWizardDialog() MBasicFactory.java /org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/ui/basic line 121 @since tag problem The method org.eclipse.e4.ui.model.application.MApplication.getDialogs() in an interface that is intended to be implemented has been added MApplication.java /org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application line 138 Compatibility Problem Missing @since tag on createDialog() MBasicFactory.java /org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/ui/basic line 112 @since tag problem See my proposed fix in https://git.eclipse.org/r/18399 Your API baseline should be set to 4.3.0 PW
Pushed a revised patch that put the @noimplement tag into the .ecore model (for all types): https://git.eclipse.org/r/18399
Pushed updated UIEvents to reflect the new model fields. https://git.eclipse.org/r/18516
(In reply to Paul Elder from comment #5) > Pushed updated UIEvents to reflect the new model fields. > > https://git.eclipse.org/r/18516 Published to master as: https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fa91fd45ca025787f1bf6e04e7e042ad7424c2ec
I am trying to implement these in the model editor but they don't extend MContribution and hence I cannot set the implementing class. I sort of expected that.. Is the idea behind the implementation of Dialogs to behave just like windows, i.e. as containers for elements like MPart? Interesting. Can you try to explain how you visualize the MDialog implementation?
Isn't that already implemented?
I think Paul Elder fixed that. Marking as fixed.
Verified in 4.4.0.I20140501-0200. Still no idea what to do with these though....
(In reply to Lars Vogel from comment #8) > Isn't that already implemented? What do you mean Lars?
(In reply to Wim Jongman from comment #11) > What do you mean Lars? This bug was still open, so I marked it as fixed.
*** Bug 324956 has been marked as a duplicate of this bug. ***
