This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 421298 - eclipse.platform remove retired project folder
Summary: eclipse.platform remove retired project folder
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M4   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 420779
  Show dependency tree
 
Reported: 2013-11-08 01:30 EST by Lars Vogel CLA
Modified: 2013-12-12 06:33 EST (History)
6 users (show)

See Also:


Attachments
Project Import before cleanup (96.85 KB, image/png)
2013-11-08 01:30 EST, Lars Vogel CLA
no flags Details
Project Import after cleanup (79.72 KB, image/png)
2013-11-08 01:30 EST, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2013-11-08 01:30:18 EST
Created attachment 237294 [details]
Project Import before cleanup

If I select import project on eclipse.platform I see lots of "removed" plug-ins which I still can import. I thing these "dead" projects should be removed so that new contributors can find faster the still relevant projects

The easiest solution is IMHO to remove the .project files so that Eclipse will not suggest to import them. I don't think this will do any harm.

org.eclipse.update
org.eclipse.update.core.linux
org.eclipse.update.core.win32
org.eclipse.update.examples
org.eclipse.update.scheduler
org.eclipse.update.tests.core
org.eclipse.update.ui.forms
org.eclipse.update.ui.win32
org.eclipse.update.ui
Comment 1 Lars Vogel CLA 2013-11-08 01:30:45 EST
Created attachment 237295 [details]
Project Import after cleanup
Comment 2 Lars Vogel CLA 2013-11-08 01:33:48 EST
https://git.eclipse.org/r/18210
Comment 3 Krzysztof Daniel CLA 2013-11-08 03:22:37 EST
I like the idea. But maybe instead of removing - rename (like .project_deleted)? This will still hide them, but resurrecting them will be much easier (if someone ever is interested).
Comment 4 David Williams CLA 2013-11-08 04:08:09 EST
I prefer more radical pruning ... since, what your are suggesting still leaves a lot of "extra stuff" checked out on file system, such as during builds, or for those that use command line, for one thing or another, or if/when the repo is checked out as "one big project" instead of small, Eclipse projects. 

I think if something is tagged, with an annotated tag, that will keep it in Git forever (i.e. won't be garbage collected) and if well document in bugzilla, that suffices. 

This is just my perspective as "releng", since I often need to get "whole repo" to search "everywhere to find if/where a particular bundle or construct might be used" and best avoid a lot of "false hits". 

Just my 2 cents. 

I can see how best solution may depend on reason its being removed or the component its in.
Comment 5 Krzysztof Daniel CLA 2013-11-08 04:41:02 EST
(In reply to David Williams from comment #4)
> more radical pruning ... 

That's something I was even afraid to think of. Actually I'm still afraid of.
But like it :-).
Comment 6 Lars Vogel CLA 2013-11-08 09:01:12 EST
(In reply to David Williams from comment #4)
> I prefer more radical pruning ... since, what your are suggesting still
> leaves a lot of "extra stuff" checked out on file system, such as during
> builds, or for those that use command line, for one thing or another, or
> if/when the repo is checked out as "one big project" instead of small,
> Eclipse projects. 
> 
> I think if something is tagged, with an annotated tag, that will keep it in
> Git forever (i.e. won't be garbage collected) and if well document in
> bugzilla, that suffices. 

I didn't dare to delete the folder but I completely agree that this would be the best thing to do. I love cleanup, and completely deleting outdated stuff is helpful for newcomers. As Kris, I did not dare to do so but I update my patch. 

Thanks.
Comment 7 Paul Webster CLA 2013-11-08 09:26:22 EST
If these projects aren't included in the build in Kepler, why not just delete them like we did for the r21 presentation bundle?

PW
Comment 8 Lars Vogel CLA 2013-11-08 11:19:52 EST
(In reply to Paul Webster from comment #7)
> If these projects aren't included in the build in Kepler, why not just
> delete them like we did for the r21 presentation bundle?
> 
> PW

This makes me happy. 

https://git.eclipse.org/r/18210
Comment 9 Dani Megert CLA 2013-11-12 11:00:13 EST
(In reply to Lars Vogel from comment #8)
> (In reply to Paul Webster from comment #7)
> > If these projects aren't included in the build in Kepler, why not just
> > delete them like we did for the r21 presentation bundle?
> > 
> > PW
> 
> This makes me happy. 
> 
> https://git.eclipse.org/r/18210

Submitted with http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=913f6d9f7ccc6a209b8451dc8a78e6ef8a3e5b88

and removed unused references from the platform-feature/pom.xml with http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=fa32e07bfcf194b5ba7803383502d8bc8550db53
Comment 10 Lars Vogel CLA 2013-12-12 06:33:00 EST
Verified in the Git repo.