Community
Participate
Working Groups
We got png images contributed to the platform (hurra). The org.eclipse.ui.images should be added to the platform build. There is not source to build, just the png files to added so that other plug-ins can use them. Do we have already a resource bundle only so that I can peek how to setup pom.xml for the build?
I'm not sure what the icons are for, but to my knowledge, they usually just "go with" the bundle they are related to ... such as see org.eclipse.jface, org.eclipse.ui, or org.eclipse.ui.browser. There's not a single "resource only" bundle. There's nothing needed in pom to get them included in a build, just put them in in a directory such as "icons" and then makes sure 'icons' is listed in your build.properties bin.includes, such as bin.includes = icons/,\ ... And Tycho will include them. If you are talking about the "branding" icons, that is a little different. And, ... I'm learning ... best to put those directly in the "product" folder (which in our case, are all under eclipse.platform.releng.tychoeclipsebuilder which is a project and is in eclipse.platform.releng.aggregator but, is not a submodule. I'm sure there's other options that might need some clarification/discussion if your case isn't covered by the above. HTH
(In reply to David Williams from comment #1) > I'm not sure what the icons are for, but to my knowledge, they usually just > "go with" the bundle they are related to ... such as see org.eclipse.jface, > org.eclipse.ui, or org.eclipse.ui.browser. There's not a single "resource > only" bundle. Thanks for the reply. In Bug 385003 Comment 25 Paul Webster suggested to create a new bundle called "org.eclipse.ui.images" which would contain the new images. Originally I also assumed that images must be part of their consuming plug-in but Paul suggested to use the platform:/plugin/org.eclipse.ui.images/...path... to refer to them. I really like Pauls idea because this gives us (and RCP applications) one central "image" bundle which can be easily reused. I hope I explained myself better this time. :-) I try later to setup a pom.xml for the new bundle and upload it as Gerrit review.
Sounds like a fine idea ... don't think we have any existing examples. Should still all "just work" without any fancy POM work (i.e. POM would be like for any other bundle) but technically, a pure "resource only" bundle does not need a BREE in the manifest, (and does not need a classpath, Java Nature, etc.) ... but as far as I know, Tycho will still "honor" the "bin.includes" directive to copy those resources to /target. Would still need to be listed as a <module> in "repo pom" and would still have to be listed in a feature somewhere to make sure it gets "included" ... just like any other bundle. As far as I know.
Lars, you can give it a pom similar to org.eclipse.core.commands, and then add it to the eclipse.platform.ui/pom.xml PW
https://git.eclipse.org/r/#/c/18231/
Dani Meggert suggested that we should not include this bundle into the build, as it is only used as temporary source of images. The images will be copied into their consuming plug-ins. I tried to revert the change via Gerrit but this seem to have not worked. I revert it directly.
(In reply to Lars Vogel from comment #6) > Dani Meggert suggested that we should not include this bundle into the > build, as it is only used as temporary source of images. The images will be > copied into their consuming plug-ins. > > I tried to revert the change via Gerrit but this seem to have not worked. I > revert it directly. This is still in. You need to restore https://git.eclipse.org/r/#/c/20740/1 and then submit it.
(In reply to Dani Megert from comment #7) > This is still in AFAIK we are not allowed to commit to master at the moment. I have revert this in a new Gerrit review but await the comment that we are allowed to commit to master again. https://git.eclipse.org/r/#/c/20880/
(In reply to Lars Vogel from comment #8) > (In reply to Dani Megert from comment #7) > > > This is still in > > AFAIK we are not allowed to commit to master at the moment. I have revert > this in > a new Gerrit review but await the comment that we are allowed to commit to > master again. > > https://git.eclipse.org/r/#/c/20880/ Regressions that are announced on the mailing list can be committed, as per Paul's note.
Reverted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3d47c75aaa3eaadeb5227361aad4a6861c12a55e We don't want to include the image plug-in into the platform build
(In reply to Lars Vogel from comment #2) > (In reply to David Williams from comment #1) > > I'm not sure what the icons are for, but to my knowledge, they usually just > > "go with" the bundle they are related to ... such as see org.eclipse.jface, > > org.eclipse.ui, or org.eclipse.ui.browser. There's not a single "resource > > only" bundle. > > Thanks for the reply. In Bug 385003 Comment 25 Paul Webster suggested to > create a new bundle called "org.eclipse.ui.images" which would contain the > new images. Originally I also assumed that images must be part of their > consuming plug-in but Paul suggested to use the > platform:/plugin/org.eclipse.ui.images/...path... to refer to them. > > I really like Pauls idea because this gives us (and RCP applications) one > central "image" bundle which can be easily reused. > > I hope I explained myself better this time. :-) > > I try later to setup a pom.xml for the new bundle and upload it as Gerrit > review. Hi Lars, if I understand this comment correctly you have plans to move the icons out of the various bundles (e.g. from pde.ui) to a common images bundle and reference them via the "platform:/plugin/org.eclipse.ui.images/...path..." mechanism. Correct? Is this centralisation of the images still on the agenda of the eclipse team? Regards, Matthias
