Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 421155 - [RenderingEngine] Main toolbar not redrawn when maximized Welcome closed 2nd time
Summary: [RenderingEngine] Main toolbar not redrawn when maximized Welcome closed 2nd ...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 387161
Blocks:
  Show dependency tree
 
Reported: 2013-11-06 08:22 EST by Markus Keller CLA
Modified: 2019-11-23 13:51 EST (History)
3 users (show)

See Also:


Attachments
Screenshot of 4.3.1 (47.60 KB, image/png)
2013-11-06 08:22 EST, Markus Keller CLA
no flags Details
I20140601-2000 (after 4.4 RC3) (35.22 KB, image/png)
2014-06-02 09:50 EDT, Markus Keller CLA
no flags Details
Classic (I20140604-2000) (31.25 KB, image/png)
2014-06-05 12:03 EDT, Markus Keller CLA
no flags Details
workbench.xmi from running workbench (248.82 KB, application/octet-stream)
2014-06-05 13:46 EDT, Markus Keller CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-11-06 08:22:04 EST
Created attachment 237233 [details]
Screenshot of 4.3.1

4.3, 4.3.1, and I20131105-0800

- start new workspace
- close Welcome
- choose Help > Welcome
- close Welcome by clicking the X in the part tab

When Welcome is closed the second time, the main toolbar is not properly redrawn. The tool items only become visible when you hover over them or resize the window.
Does not occur when you click the "Workbench" button to close the Welcome part.
Does not occur the first time Welcome is closed.

Bug 387002 comment 3 says bug 387161 is still open. Maybe that's the issue here? I don't understand the implications of that bug. This bug could be dup of that one.
Comment 1 Markus Keller CLA 2014-06-02 09:50:02 EDT
Created attachment 243798 [details]
I20140601-2000 (after 4.4 RC3)

In I20140601-2000 and in 4.2.2, the toolbar buttons are painted properly, but the borders on top and bottom of the toolbar are not redrawn until I resize the window horizontally. The black line between Quick Access and Perspective Switcher is not always that prominent.

Maybe influenced by the native Browser widget. I'm still on IE8.
Comment 2 Eric Moffatt CLA 2014-06-02 11:03:23 EDT
Markus, I can't seem to repo this (Windows 7 /w Windows 7 Blue theme), is it perhaps CSS related...i.e. do other themes show similar repaint issues ?
Comment 3 Markus Keller CLA 2014-06-05 12:03:15 EDT
Created attachment 244007 [details]
Classic (I20140604-2000)

I'm also on Windows 7, but I've disabled some fancy features like transparent window frames and font smearing.

In the Windows 7 theme, I see the cheese about every second time I close Welcome by clicking the X in the part tab. In between, the toolbar is rendered properly.

In the Classic and Windows 7 Classic themes, it's even worse in that the buttons are almost never drawn correctly after closing Welcome (see screenshot).
Comment 4 Eric Moffatt CLA 2014-06-05 13:05:30 EDT
Markus, your last screenshot looks *very* strange. At the upper left there's two odd things: 

there's what looks to be a vertical minimized stack directly under the main menu (indicating that there's no top trim visible at all).

There's what appears to be an empty stack there as well just to the right of it.

I'm presuming that resizing the window fixes everything ?

Is it possible that this is particular to your workbench.xmi or does it happen for all of your workspaces ? If you attach the workbench.xmi I can try it out here (I'm on Windows 7).
Comment 5 Markus Keller CLA 2014-06-05 13:46:39 EDT
Created attachment 244012 [details]
workbench.xmi from running workbench

(In reply to Eric Moffatt from comment #4)
> Markus, your last screenshot looks *very* strange.

Yes. This happens in a brand new workspace in a brand new install of I20140604-2000 when I close Welcome, switch to the Classic theme, restart, open Welcome, and click the X.

In the default (Windows 7) theme, the cheese goes away when I resize the window horizontally. In the Classic theme, it's worse: There, enabled toolbar buttons are redrawn when I move the mouse over them. Resizing the window doesn't remove the cheese. Toolbar items are only redrawn when I make the window so narrow that they wrap to the second line. I can't make the disabled Save / Save All / Print buttons appear by resizing. The only real remedy is to restart Eclipse or to open Welcome and then close it using the "Workbench" button on the Welcome page.

> Is it possible that this is particular to your workbench.xmi or does it
> happen for all of your workspaces ? If you attach the workbench.xmi I can
> try it out here (I'm on Windows 7).

It doesn't happen in all workspaces (e.g. not in my main dev workspace). It happens always in brand-new workspaces.

I'm attaching the workbench.xmi, but I doubt that the problem is really in the model. The "emtpy stack" the screenshot doesn't react like a stack when I move the mouse over it -- instead, I suddenly get the "New" button.
Comment 6 Udo Walker CLA 2015-08-18 00:39:22 EDT
I get this damaged toolbar only if I miss configure a menu extension in my own plugin.xml. The Eclipse framework which handles menu extensions is not robust against wrong configurations. Instead the toolbars/menus are damaged or not visible at all.

I suggest that in the mentioned integration build of Eclipse I20131105-0800 some configuration in one of the hundreds of plug-ins is wrong so that when the welcome screen is closed and some context is active the configuration is damaged and then everything is damaged.
Comment 7 Eclipse Genie CLA 2019-11-23 13:51:48 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.