Community
Participate
Working Groups
One of the things we would like to provide for JS tools - and more generally for any editable file that has an outline - would be the quick access popup like we had in Eclipse (Ctrl+O). Currently though that keybinding is mapped to closing / opening the navigator side panel. Could we pick an alternate keybinding for opening / closing the side panel so we can use Ctrl+O for a quick outline by default?
Related bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=411518
I would like this too. Since the left-hand panel rarely shows an outline these days, we can probably justify moving it to a keybinding that doesn't have 'O' in it at all.
Pushed to gerrit: https://git.eclipse.org/r/19219 How does Ctrl (Command) + Shift + P sound?
(In reply to Michael Rennie from comment #3) > Pushed to gerrit: https://git.eclipse.org/r/19219 > > How does Ctrl (Command) + Shift + P sound? Its a no-go, Ctrl+Shift+P cause problems on windows and opens a new private browsing tab in Firefox. I abandoned the other change and pushed a new one to: https://git.eclipse.org/r/19261 that uses Ctrl (Command) + Shift + e - tested on Safari /Firefox/Chrome on Mac OS does not cause any problems.
(In reply to Michael Rennie from comment #4) > I abandoned the other change and pushed a new one to: > https://git.eclipse.org/r/19261 that uses Ctrl (Command) + Shift + e - > tested on Safari /Firefox/Chrome on Mac OS does not cause any problems. Ctrl (Command) + Shift + E overrides the expose feature of Firefox. Will anyone miss it? I actually did not know it existed up to now. Initially I thought we could use (Ctrl + Shift + L) (L for Left Side). It does not seem to be used by any browser. Note that it is ctrl on Mac too since Cmd+Shift+L is taken on Safari to show their sidebar. new KeyBinding.KeyBinding('l', util.isMac ? false : true, true, false, util.isMac ? true : false)
(In reply to Silenio Quarti from comment #5) > (In reply to Michael Rennie from comment #4) > > I abandoned the other change and pushed a new one to: > > https://git.eclipse.org/r/19261 that uses Ctrl (Command) + Shift + e - > > tested on Safari /Firefox/Chrome on Mac OS does not cause any problems. > > Ctrl (Command) + Shift + E overrides the expose feature of Firefox. Will > anyone miss it? I actually did not know it existed up to now. > > Initially I thought we could use (Ctrl + Shift + L) (L for Left Side). It > does not seem to be used by any browser. Note that it is ctrl on Mac too > since Cmd+Shift+L is taken on Safari to show their sidebar. > > new KeyBinding.KeyBinding('l', util.isMac ? false : true, true, false, > util.isMac ? true : false) In Chrome on Mac, when in the editor Ctrl+Shift+L doesn't do anything, outside the editor it works as expected
(In reply to Michael Rennie from comment #6) > (In reply to Silenio Quarti from comment #5) > > (In reply to Michael Rennie from comment #4) > > > I abandoned the other change and pushed a new one to: > > > https://git.eclipse.org/r/19261 that uses Ctrl (Command) + Shift + e - > > > tested on Safari /Firefox/Chrome on Mac OS does not cause any problems. > > > > Ctrl (Command) + Shift + E overrides the expose feature of Firefox. Will > > anyone miss it? I actually did not know it existed up to now. > > > > Initially I thought we could use (Ctrl + Shift + L) (L for Left Side). It > > does not seem to be used by any browser. Note that it is ctrl on Mac too > > since Cmd+Shift+L is taken on Safari to show their sidebar. > > > > new KeyBinding.KeyBinding('l', util.isMac ? false : true, true, false, > > util.isMac ? true : false) > > In Chrome on Mac, when in the editor Ctrl+Shift+L doesn't do anything, > outside the editor it works as expected I pushed an updated fix using Ctrl+Shift+L to gerrit
(In reply to Michael Rennie from comment #6) > > new KeyBinding.KeyBinding('l', util.isMac ? false : true, true, false, > > util.isMac ? true : false) > > In Chrome on Mac, when in the editor Ctrl+Shift+L doesn't do anything, > outside the editor it works as expected This is a bug in commands.js detecting content keys. On Mac, a key event with the CTRL modifier does not generate a character. I pushed this fix: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2791fe270e9758d9d74c3dd81d6c289b5c296135
(In reply to Silenio Quarti from comment #8) > (In reply to Michael Rennie from comment #6) > > > new KeyBinding.KeyBinding('l', util.isMac ? false : true, true, false, > > > util.isMac ? true : false) > > > > In Chrome on Mac, when in the editor Ctrl+Shift+L doesn't do anything, > > outside the editor it works as expected > > This is a bug in commands.js detecting content keys. On Mac, a key event > with the CTRL modifier does not generate a character. I pushed this fix: > > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/ > ?id=2791fe270e9758d9d74c3dd81d6c289b5c296135 Perfect. The other fix was merged from gerrit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1b953033f3a87a23f4d9fc067782afbc7cadb713
